[RFC] Repo tidy ups #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukester1975
force-pushed
the
repo-tidy
branch
from
59dd732
to
13c98d7
Compare
lukester1975
force-pushed
the
repo-tidy
branch
from
13c98d7
to
e588dca
Compare
|
Luke, want to split the prettier stuff into another PR and this one can be just for commitlint? That way focus can be on one thing at a time? |
|
Sure I can give it a whirl when I get a moment. |
|
Once the other PR is merged, do we need to add commitlint or anything else from this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wondered if you'd like to use husky with prettier and commitlint to enforce some styling of code and commits?
I didn't like prettier at first (it doesn't format code exactly like I do!) but once I got used to letting it do its thing and not worry about it, it's just nice to have everything consistently styled. That said I don't get the predilection for 80 columns hence the custom setting. Anyway, just an idea. If you'd like to use it I can update the PR to whatever prettier/commitlint configs you like. Works OK on Windows as long as git is in the path.
3rd commit is to add standard-version for changelogs and tags if the commitlint is a go-er. I'm not sure what the current release procedure is, so might not be directly applicable and there's no single script in this, but manually
yarn release && yarn packagewould do the trick.And then one last one to have a single resources directory - couldn't see the need for separate ones but I may be missing something!
Regards