Prevent licensed users from rebroadcasting unlicensed traffic #6068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is (on 2.6), licensed users have rebroadcast_mode set to LOCAL_ONLY and this requires that all channels have no encryption keys, so we are effectively preventing encrypted traffic from traversing the mesh. We currently rebroadcast any plaintext traffic in good faith.
This PR takes the distinction a step further by asserting that if we have an unecrypted packet and we know that the user does not claim to be licensed, we should not rebroadcast that packet.