Reject invalid configuration for the default MQTT server #6066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esev
force-pushed
the
validate-default-mqtt
branch
from
b6f6cd1 to
3e9894d
Compare
esev
force-pushed
the
validate-default-mqtt
branch
from
5f27fbb to
607be47
Compare
fifieldt
approved these changes
Feb 16, 2025
thebentern
approved these changes
Feb 16, 2025
dchokola
pushed a commit
to dchokola/meshtastic-firmware
that referenced
this pull request
Feb 16, 2025
…6066) * Sanity check configuration for the default MQTT server * Skip for MESHTASTIC_EXCLUDE_MQTT --------- Co-authored-by: Ben Meadors <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A MQTT configuration change will be rejected if the default server is used and:
This PR is addresses the additional feedback from #6056 (comment)