Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Update meshkit and docker #211

Merged
merged 8 commits into from
Aug 18, 2023
Merged

[chore] Update meshkit and docker #211

merged 8 commits into from
Aug 18, 2023

Conversation

nebula-aac
Copy link
Contributor

Description

This PR updates meshkit to v0.6.48 and updates docker to v20 instead of v17.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@nebula-aac
Update meshkit and docker
b7f7952 
Signed-off-by: Antonette Caldwell <[email protected]>
@welcome
Copy link

welcome bot commented Jul 12, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@leecalcote
Copy link
Member

@Aritra8438 Do you mind reviewing this PR?

@leecalcote
Copy link
Member

leecalcote commented Aug 16, 2023 •
edited
Loading

Conflicts resolved.

@leecalcote leecalcote added language/go Golang related pr/dependencies Dependabot or manual dependencies addressed in this PR kind/chore Necessary task labels Aug 16, 2023
@Aritra8438
Copy link
Contributor

@Aritra8438 Do you mind reviewing this PR?

Will try my best @leecalcote

@leecalcote
Copy link
Member

I can't assign your user to a review, but you should be able to offer comment when you do review, @Aritra8438

Aritra8438
Aritra8438 reviewed Aug 17, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
leecalcote
leecalcote reviewed Aug 17, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@leecalcote
Update go.mod
0ce73cc 
Signed-off-by: Lee Calcote <[email protected]>
@leecalcote
Copy link
Member

@nebula-aac is this ready for merge?

@leecalcote
Copy link
Member

@Aritra8438 how are we looking now?

@leecalcote leecalcote merged commit ae44b36 into meshery:master Aug 18, 2023
2 checks passed
@welcome
Copy link

welcome bot commented Aug 18, 2023

Thanks for your contribution to the Meshery community! 🎉
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

Shows a black logo in light color mode and a white one in dark color mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aritra8438 Aritra8438 Aritra8438 left review comments

@leecalcote leecalcote leecalcote left review comments

Assignees
No one assigned
Labels
kind/chore Necessary task language/go Golang related pr/dependencies Dependabot or manual dependencies addressed in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nebula-aac @leecalcote @Aritra8438