Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade meshkit Go version from 1.21 to 1.23 #627

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+8 −8
Open

Upgrade meshkit Go version from 1.21 to 1.23 #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f71321
update Go version from 1.21 to 1.23 in go.mod
devhindo Dec 21, 2024
3168827
update Go version to 1.23 in CI workflows
devhindo Dec 21, 2024
3028e25
update Go version to 1.23.4 in Makefile
devhindo Dec 21, 2024
8383229
update golangci-lint and setup-go actions to latest versions in CI wo…
devhindo Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ jobs:
- uses: actions/checkout@master
- uses: actions/setup-go@master
with:
go-version: '1.21'
go-version: '1.23'
cache: true
cache-dependency-path: go.sum
- name: golangci-lint
uses: golangci/golangci-lint-action@v4.0.0
uses: golangci/golangci-lint-action@v6
with:
version: latest
- name: Run golangci-lint
Expand All @@ -31,7 +31,7 @@ jobs:
- uses: actions/checkout@master
- uses: actions/setup-go@master
with:
go-version: '1.21'
go-version: '1.23'
cache: true
cache-dependency-path: go.sum
- name: go mod tidy
Expand All @@ -42,9 +42,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: actions/setup-go@v4
- uses: actions/setup-go@v5
with:
go-version: '1.21'
go-version: '1.23'
cache: true
cache-dependency-path: go.sum
- name: test
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/error-codes-updater.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@master
with:
go-version: ${{ secrets.GO_VERSION }}
go-version: '1.23'

- name: Run utility
run: |
Expand Down
2 changes: 1 addition & 1 deletion build/Makefile.core.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
GIT_VERSION = $(shell git describe --tags `git rev-list --tags --max-count=1`)
GIT_COMMITSHA = $(shell git rev-list -1 HEAD)

GOVERSION = 1.19.1
GOVERSION = 1.23.4
GOPATH = $(shell go env GOPATH)
GOBIN = $(GOPATH)/bin

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/layer5io/meshkit

go 1.21
go 1.23

replace (
github.com/Sirupsen/logrus => github.com/sirupsen/logrus v1.9.3
Expand Down