Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go upgrade #624

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

go upgrade #624

wants to merge 7 commits into from

Conversation

weilirs
Copy link

@weilirs weilirs commented Dec 15, 2024

Description

This PR fixes meshery/meshery#12829

Notes for Reviewers
secrets.GO_VERSION needs to be upgraded as well

Signed commits

  • Yes, I signed my commits.

Signed-off-by: weilirs <[email protected]>
Copy link

welcome bot commented Dec 15, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Signed-off-by: weilirs <[email protected]>
@weilirs
Copy link
Author

weilirs commented Dec 15, 2024

@leecalcote
To test it with Meshery server, is it to run go build ./... and add replace github.com/layer5io/meshkit => /path/to/local/meshkit to the Meshery server and then run go test?

@weilirs
Copy link
Author

weilirs commented Dec 18, 2024

I ran go build ./... in Meshkit.
Then I added this line github.com/layer5io/meshkit => /Users/macbookpro/Documents/meshkit to the Meshery server's go.mod's "replace" clause.
Then I ran make server and check http://localhost:9081. It is working fine now.

@leecalcote
Copy link
Member

@weilirs good work.

Do you know why we're seeing these build check failures? https://github.com/meshery/meshkit/actions/runs/12401032586/job/34619527275?pr=624#step:4:28

@weilirs
Copy link
Author

weilirs commented Dec 18, 2024

@weilirs good work.

Do you know why we're seeing these build check failures? meshery/meshkit/actions/runs/12401032586/job/34619527275?pr=624#step:4:28

Let me check this out

@weilirs
Copy link
Author

weilirs commented Dec 19, 2024

@weilirs good work.

Do you know why we're seeing these build check failures? https://github.com/meshery/meshkit/actions/runs/12401032586/job/34619527275?pr=624#step:4:28

golangci-lint-action and make check both run golangci-lint so I added skip-cache = true to skip the second lint run
And there are some unused variables and function so I added //nolint:unused to temporarily skip them

@weilirs
Copy link
Author

weilirs commented Dec 19, 2024

It seems most of the recent PRs fail this check

--- FAIL: TestValidator (0.01s)

    validate_test.go:70: unknown domain for reference "../core.json#/definitions/uuid" (and 4 more errors)

    validate_test.go:70: unknown domain for reference "../core.json#/definitions/uuid" (and 4 more errors)

    validate_test.go:80: test failed for catalog_data, got true, want true error: <nil>

    validate_test.go:70: unknown domain for reference "../core.json#/definitions/uuid" (and 4 more errors)

    validate_test.go:80: test failed for models, got true, want true error: <nil>

FAIL

coverage: 67.4% of statements

FAIL	github.com/layer5io/meshkit/validator	0.050s

FAIL

make: *** [Makefile:10: test] Error 1

@weilirs weilirs requested a review from leecalcote December 19, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Meshery Server and all Components to Golang 1.23.4
2 participants