Fix the method for converting Docker Compose to K8 Manifest. #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pratham <[email protected]>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
|
@leecalcote can you please review it? |
|
@nebula-aac, help, help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kind: Listwas discarded by kompose in kubernetes/kompose#1541. That's why Meshkit is unable to format the output and is returning an empty K8 manifest string.kompose (> 1.31.1)can support Docker Compose 3.9, although not the version (v1.26.2) used inmeshery/meshery.We can simplify the implementation of the Convert method by updating kompose and using the new client/interface (kubernetes/kompose#1593). We will need to bump the kompose version in meshery too.
Also, it seems there is no support for Profiles in meshery. Right now it is simply ignored. Meshery's API and UI will need to be updated to accommodate it.
This PR fixes:
meshery/meshery#12495
Part of meshery/meshery#10450
Notes for Reviewers
Removing the format function and returning the output without formatting can be a straightforward fix. (quick fix).
Signed commits