Add Minify and Flatten for In-cluster deployment with Minikube #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or=Alero Awani <[email protected]> Signed-off-by: Alero Awani <[email protected]>
…uthor=Alero Awani <[email protected]> Signed-off-by: Alero Awani <[email protected]>
|
Thanks for tackling this, @Alero-Awani |
|
@Alero-Awani Can you fix these lint failures? then we are good to go. |
MUzairS15
suggested changes
Sep 19, 2024
utils/kubernetes/client.go
Outdated
| if err != nil { | ||
| return nil, ErrValidateConfig(err) | ||
| return nil, nil, err |
There was a problem hiding this comment.
Please reuse/define a new meshkit error.
utils/kubernetes/client.go
Outdated
| if err != nil { | ||
| return nil, ErrLoadConfig(err) | ||
| return nil, nil, err |
There was a problem hiding this comment.
Please reuse/define a new meshkit error.
There was a problem hiding this comment.
Alright Noted! Thank you for the review 😃
Signed-off-by: Alero Awani <[email protected]>
Alero-Awani
force-pushed
the
meshkit-minify
branch
from
1f35774
to
5614a67
Compare
MUzairS15
reviewed
Sep 23, 2024
utils/kubernetes/client.go
Outdated
| if err != nil{ | ||
| return nil, err | ||
| } | ||
| if config, err = clientcmd.RESTConfigFromKubeConfig(cfgFile); err == nil { | ||
| return config, err |
There was a problem hiding this comment.
Suggested change
| return config, err | |
| return config, err |
While this is not immediately due to your changes, you can improve the logic to ensure meshkit error is returned while you are here.
There was a problem hiding this comment.
Alright thank you for this. I will keep in mind to prioritize returning Meshkit errors
…[email protected]> Signed-off-by: Alero Awani <[email protected]>
Signed-off-by: Mohd Uzair <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a central function
ProcessConfigfor processing kubeconfig files, encapsulating the functionality for loading, validating, and writing kubeconfig files, whether from a file location or a []byte input.The function has been integrated into the
DetectKubeConfig, addressing this issue which specifically occurs when running the commandmesheryctl system start -p Kubernetes.Fixes #11546
Signed commits