support generation of model from openapi schemas #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2024 19:34
Signed-off-by: MUzairS15 <[email protected]>
Signed-off-by: MUzairS15 <[email protected]>
leecalcote
reviewed
Sep 6, 2024
Signed-off-by: MUzairS15 <[email protected]>
|
ensure correct version is passed. |
MUzairS15
commented
Sep 13, 2024
utils/component/openapi_generator.go
Outdated
| "github.com/meshery/schemas/models/v1beta1/model" | ||
| ) | ||
|
|
||
| func GenerateFromOpenAPI(resource string) ([]component.ComponentDefinition, error) { |
There was a problem hiding this comment.
pass the "pkg" that contains info regarding model to generate.
|
// @Jougan-0 |
added 4 commits
September 25, 2024 14:09
Signed-off-by: MUzairS15 <[email protected]>
Signed-off-by: MUzairS15 <[email protected]>
Signed-off-by: MUzairS15 <[email protected]>
Signed-off-by: MUzairS15 <[email protected]>
added 3 commits
September 30, 2024 15:31
Signed-off-by: MUzairS15 <[email protected]>
Signed-off-by: MUzairS15 <[email protected]>
Signed-off-by: MUzairS15 <[email protected]>
MUzairS15
commented
Sep 30, 2024
| Name: pkg.GetName(), | ||
| DisplayName: manifests.FormatToReadableString(pkg.GetName()), | ||
| Category: category.CategoryDefinition{ | ||
| Name: "Orchestration & Management", |
leecalcote
reviewed
Sep 30, 2024
| DisplayName: manifests.FormatToReadableString(kind), | ||
| Model: model.ModelDefinition{ | ||
| SchemaVersion: v1beta1.ModelSchemaVersion, | ||
| Version: "v1.0.0", |
There was a problem hiding this comment.
Why is this still hardcoded?
leecalcote
reviewed
Sep 30, 2024
|
|
||
| c := component.ComponentDefinition{ | ||
| SchemaVersion: v1beta1.ComponentSchemaVersion, | ||
| Version: "v1.0.0", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #
Notes for Reviewers
Signed commits