-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source class description from schema #542
base: master
Are you sure you want to change the base?
Source class description from schema #542
Conversation
Signed-off-by: Shubham Upadhyay <[email protected]>
Signed-off-by: Shubham Upadhyay <[email protected]>
This PR depends on meshery/schemas new version, don't merge this until we release new version of schemas repo |
Lint failure will get pass as we will make Schemas repo release |
Signed-off-by: Shubham Upadhyay <[email protected]>
Signed-off-by: Shubham Upadhyay <[email protected]>
Lint is failing because of other PR, this PR depends on schemas repo new release |
Signed-off-by: Shubham Upadhyay <[email protected]>
Schema is bumped, good to merge this PR if looks good |
Do a proper bump of schema Signed-off-by: Shubham Upadhyay <[email protected]>
Shubham test failing, Uhh ho! looks like validator test failing because changes made in schemas v0.7.11 version, @MUzairS15 will this schema bump will cause issues in validator? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yashsharma1911 There’s an existing functionality to retrieve schema for resources, can you try using that instead?
I tried but I wasn't able to find it, if you can share 😅 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@Yashsharma1911 can you help finish this off? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
This PR fixes #
This PR update catalog to source class description from schema
Notes for Reviewers
Signed commits