Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source class description from schema #542

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

shubham251972
Copy link
Contributor

@shubham251972 shubham251972 commented Jul 20, 2024

Description

This PR fixes #

This PR update catalog to source class description from schema

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Shubham Upadhyay <[email protected]>
@shubham251972
Copy link
Contributor Author

This PR depends on meshery/schemas new version, don't merge this until we release new version of schemas repo

@shubham251972
Copy link
Contributor Author

Lint failure will get pass as we will make Schemas repo release

models/catalog/v1alpha1/catalog.go Outdated Show resolved Hide resolved
@shubham251972
Copy link
Contributor Author

Lint is failing because of other PR, this PR depends on schemas repo new release

Signed-off-by: Shubham Upadhyay <[email protected]>
@shubham251972
Copy link
Contributor Author

shubham251972 commented Aug 1, 2024

Lint is failing because of other PR, this PR depends on schemas repo new release

Schema is bumped, good to merge this PR if looks good

Do a proper bump of schema

Signed-off-by: Shubham Upadhyay <[email protected]>
@Yashsharma1911
Copy link
Contributor

Shubham test failing, Uhh ho! looks like validator test failing because changes made in schemas v0.7.11 version, @MUzairS15 will this schema bump will cause issues in validator?

Copy link

@MUzairS15 MUzairS15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yashsharma1911 There’s an existing functionality to retrieve schema for resources, can you try using that instead?

@Yashsharma1911
Copy link
Contributor

@Yashsharma1911 There’s an existing functionality to retrieve schema for resources, can you try using that instead?

I tried but I wasn't able to find it, if you can share 😅

Copy link

stale bot commented Sep 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Sep 17, 2024
@leecalcote
Copy link
Member

@Yashsharma1911 can you help finish this off?

@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Sep 17, 2024
Copy link

stale bot commented Nov 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Nov 9, 2024
@Yashsharma1911 Yashsharma1911 added issue/willfix This issue will be worked on and removed issue/stale Issue has not had any activity for an extended period of time labels Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/willfix This issue will be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants