Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add Support for OCI #443

Merged
merged 24 commits into from
Jan 9, 2024
Merged

Feat: Add Support for OCI #443

merged 24 commits into from
Jan 9, 2024

Conversation

theBeginner86
Copy link
Member

@theBeginner86 theBeginner86 commented Jan 3, 2024 •
edited
Loading

Description

Adds functionality to:

  1. Compress into OCI Artifacts
  2. De-Compress OCI Artifacts

This would be helpful for importing/exporting Designs and Models.

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@theBeginner86
add oci.go
8c70f22 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
add artifact build support
003b4a0 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
add filesystem pkg
af0b233 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
update go.mod
4913e63 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
fix return type
1c8d89d 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
rm redudant
10e1b4d 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
update
1abf948 
Signed-off-by: Pranav Singh <[email protected]>
leecalcote
leecalcote reviewed Jan 3, 2024
View reviewed changes
models/oci/oci.go Outdated Show resolved Hide resolved
leecalcote
leecalcote reviewed Jan 3, 2024
View reviewed changes
models/oci/build.go Outdated Show resolved Hide resolved
@leecalcote leecalcote requested a review from MUzairS15 January 5, 2024 22:15
@leecalcote
Copy link
Member

@MUzairS15 you're going to want to review this.

@leecalcote
chore: shore-up go.mod
0ace040 
Signed-off-by: Lee Calcote <[email protected]>
@leecalcote leecalcote added this to the v0.8.8 milestone Jan 5, 2024
@theBeginner86 @leecalcote
Update models/oci/oci.go
a5cd4f2 
Co-authored-by: Lee Calcote <[email protected]>
Signed-off-by: Pranav Singh <[email protected]>
MUzairS15
MUzairS15 reviewed Jan 7, 2024
View reviewed changes
Copy link

@MUzairS15 MUzairS15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errors needs to be transformed into Meshkit errors.
I wonder if it's better to directly import theire packages or else if we are directly sourcing form their repo, then appropriate licensing needs to be added in the code.
// @theBeginner86

@theBeginner86 theBeginner86 mentioned this pull request Jan 8, 2024
Merged
1 task
@theBeginner86
rm unwanted files
92cc536 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
Improvise oci.go
4654841 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
add utils
571fab0 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
rm unwanted dir
de23c9b 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
mv to meshkit errors
b501096 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
Copy link
Member Author

errors needs to be transformed into Meshkit errors. I wonder if it's better to directly import theire packages or else if we are directly sourcing form their repo, then appropriate licensing needs to be added in the code. // @theBeginner86

Added MeshKit errors.
Removed duplicated code and imported the necessary functions.

@leecalcote
Copy link
Member

Re-running build...

@leecalcote
Copy link
Member

This is ready, right, @theBeginner86?

@leecalcote
Copy link
Member

Build failure...

@leecalcote
Copy link
Member

I tried, but...

@theBeginner86
add meshkit errs
0adfd7e 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
Add uncompress oci artifact support
cd56a0c 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
update
f13b612 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
Merge branch 'theBeginner86/chore/15' of https://github.com/theBeginn…
9641628 
…er86/meshkit into theBeginner86/chore/15

Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
fix golang-ci
0766cc6 
Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86
Copy link
Member Author

Build failure...

Fixed: https://github.com/meshery/meshkit/actions/runs/7462230856/job/20304075337?pr=443

@theBeginner86 theBeginner86 merged commit 21364c9 into meshery:master Jan 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote left review comments

@MUzairS15 MUzairS15 Awaiting requested review from MUzairS15

Assignees
No one assigned
Labels
area/models area/patterns
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@theBeginner86 @leecalcote @MUzairS15