Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Upgrade #12847

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Go Upgrade #12847

wants to merge 4 commits into from

Conversation

weilirs
Copy link

@weilirs weilirs commented Dec 5, 2024

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added area/ci Continuous Integration component/extensions Issues related to extension points labels Dec 5, 2024
@weilirs
Copy link
Author

weilirs commented Dec 5, 2024

I updated the version of go in these files, the next step is testing? @leecalcote

Copy link

github-actions bot commented Dec 5, 2024

@weilirs weilirs temporarily deployed to staging-playground December 5, 2024 20:29 — with GitHub Actions Inactive
@weilirs weilirs marked this pull request as ready for review December 6, 2024 13:51
@github-actions github-actions bot added the area/lifecycle Lifecycle management (install, uninstall, configure) related label Dec 6, 2024
@weilirs weilirs temporarily deployed to staging-playground December 6, 2024 14:21 — with GitHub Actions Inactive
@weilirs
Copy link
Author

weilirs commented Dec 6, 2024

After making these changes, I successfully ran make build-server and make ui-build.
For make docker build, I don't know if it is my computer lacks capacity, it got stuck at

➜  meshery git:(go-version-upgrade) ✗ make docker-build
# `make docker-build` builds Meshery inside of a multi-stage Do
# `make docker-build` builds Meshery inside of a multi-stage Docker container.
# This method does NOT require that you have Go, NPM, etc. inst
# This method does NOT require that you have Go, NPM, etc. installed locally.
DOCKER_BUILDKIT=1 docker build -f install/docker/Dockerfile -t 
DOCKER_BUILDKIT=1 docker build -f install/docker/Dockerfile -t layer5/meshery --build-arg TOKEN= --build-arg GIT_COMMITSHA=576
DOCKER_BUILDKIT=1 docker build -f install/docker/Dockerfile -t layer5/meshery --build-arg TOKEN= --build-arg GIT_COMMITSHA=5763fd32c72569aa24ecfd43168857ebaf256c80 --build-arg GIT_VERSION=v
DOCKER_BUILDKIT=1 docker build -f install/docker/Dockerfile -t layer5/meshery --build-arg TOKEN= --build-arg GIT_COMMITSHA=5763fd32c72569aa24ecfd43168857ebaf256c80 --build-arg GIT_VERSION=v0.7.167 --build-arg RELEASE_CHANNEL="edge" .
[+] Building 608.7s (31/59)               docker:desktop-linux
 => [internal] load build definition from Dockerfile     30.7s
 => => transferring dockerfile: 5.73kB                    0.0s
 => [internal] load .dockerignore                        30.3s
 => => transferring context: 2B                           0.1s
 => [internal] load metadata for docker.io/library/alpin  2.7s
 => [internal] load metadata for docker.io/layer5/getnig  2.5s
 => [internal] load metadata for docker.io/library/ubunt  2.7s
 => [internal] load metadata for docker.io/library/golan  3.1s
 => [internal] load metadata for docker.io/library/node:  2.7s
 => CACHED FROM docker.io/layer5/getnighthawk:v1.0.1@sha  0.1s
 => [seed_content 1/5] FROM docker.io/library/alpine:3.1  0.0s
 => [internal] load build context                       174.7s
 => => transferring context: 31.73MB                    170.3s
 => [wrk2 1/6] FROM docker.io/library/ubuntu@sha256:80dd  0.0s
 => [base-node 1/1] FROM docker.io/library/node:18.13.0-  0.0s
 => [meshery-server 1/5] FROM docker.io/library/golang:1  0.0s
 => CACHED [meshery-ui-provider-builder 1/4] WORKDIR /ap  0.0s
 => CACHED [seed_content 2/5] RUN apk add --no-cache cur  0.0s
 => CACHED [seed_content 3/5] RUN lines=$(curl -s https:  0.0s
 => CACHED [seed_content 4/5] RUN curl -L -s https://git  0.1s
 => CACHED [wrk2 2/6] RUN apt-get -y update && apt-get -  0.0s
 => CACHED [wrk2 3/6] RUN apt-get -y update && apt-get -  0.0s
 => CACHED [wrk2 4/6] RUN git config --global user.email  0.0s
 => CACHED [wrk2 5/6] RUN git config --global user.name   0.1s
 => CACHED [meshery-server 2/5] RUN adduser --disabled-l  0.0s
 => CACHED [meshery-server 3/5] WORKDIR /github.com/mesh  0.1s
 => [wrk2 6/6] RUN git clone --depth=1 https://github.  574.4s
 => CACHED [meshery-ui-provider-deps 1/4] RUN apk add --  0.0s
 => CACHED [meshery-ui-provider-deps 2/4] WORKDIR /app    0.0s
 => CACHED [meshery-ui-provider-deps 3/4] COPY provider-  0.0s
 => CACHED [meshery-ui-provider-deps 4/4] RUN npm ci --o  0.0s
 => CACHED [meshery-ui-deps 3/4] COPY ui/package.json ui  0.0s
 => [meshery-ui-provider-builder 2/4] COPY --from=mesh  399.6s
 => [meshery-ui-deps 4/4] RUN npm ci --omit=dev --lega  399.6s
 => [meshery-server 4/5] ADD . .                        399.0s
 => CACHED [stage-8  2/22] RUN set -ex &&     apk --upda  0.0s
 => CACHED [stage-8  3/22] RUN update-ca-certificates     0.0s
 => CACHED [stage-8  4/22] COPY ./server/cmd/server-conf  0.0s
 => [stage-8  5/22] COPY ./server/meshmodel /app/serve  399.0s

@devhindo
Copy link
Contributor

Is this done yet?

@vishalvivekm
Copy link
Contributor

@weilirs
Let's discuss this during the Meshery Development call today at 9:00 AM CT | 8:30 PM IST. Adding it as an agenda item to the meeting minutes || meeting link.

Signed-off-by: weilirs <[email protected]>
Signed-off-by: weilirs <[email protected]>
Signed-off-by: weilirs <[email protected]>
@weilirs weilirs temporarily deployed to staging-playground December 15, 2024 15:11 — with GitHub Actions Inactive
@weilirs weilirs temporarily deployed to staging-playground December 18, 2024 21:34 — with GitHub Actions Inactive
Copy link

END-TO-END TESTS

  • Testing started at: December 18th 2024, 9:42:05 pm

📦 Test Result Summary

  • ✅ 18 passed
  • ❌ 8 failed
  • ⚠️ 13 flaked
  • ⏩ 0 skipped

Duration: 7 minutes and 1 seconds

Overall Result: 👎 Some tests failed.

[Show/Hide] Test Result Details
Test Browser Test Case Tags Result
1 chromium-meshery-provider Configure Existing Istio adapter through Mesh Adapter URL from Management page unstable ⚠️
2 chromium-meshery-provider Ping Istio Adapter unstable ⚠️
3 chromium-meshery-provider Connect to Meshery Istio Adapter and configure it
4 chromium-meshery-provider Toggle "Send Anonymous Usage Statistics" unstable ⚠️
5 chromium-meshery-provider Toggle "Send Anonymous Performance Results" unstable ⚠️
6 chromium-local-provider Verify that UI components are displayed
7 chromium-local-provider Add a cluster connection by uploading kubeconfig file unstable ⚠️
8 chromium-local-provider Transition to disconnected state and then back to connected state unstable ⚠️
9 chromium-local-provider Transition to ignored state and then back to connected state unstable ⚠️
10 chromium-local-provider Transition to not found state and then back to connected state unstable ⚠️
11 chromium-local-provider Delete Kubernetes cluster connections unstable ⚠️
12 chromium-local-provider Aggregation Charts are displayed
13 chromium-local-provider Test if Left Navigation Panel is displayed
14 chromium-local-provider Test if Settings button is displayed
15 chromium-local-provider Test if Notification button is displayed
16 chromium-local-provider Test if Profile button is displayed
17 chromium-local-provider Configure Existing Istio adapter through Mesh Adapter URL from Management page unstable ⚠️
18 chromium-local-provider Ping Istio Adapter unstable ⚠️
19 chromium-local-provider Add performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
20 chromium-local-provider View detailed result of a performance profile (Graph Visualiser) with load generator "fortio" and service mesh "None" unstable ⚠️
21 chromium-local-provider Edit the configuration of a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
22 chromium-local-provider Compare test of a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
23 chromium-local-provider Delete a performance profile with load generator "fortio" and service mesh "None" unstable ⚠️
24 chromium-local-provider Connect to Meshery Istio Adapter and configure it
25 chromium-local-provider Toggle "Send Anonymous Usage Statistics" unstable ⚠️
26 chromium-local-provider Toggle "Send Anonymous Performance Results" unstable ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous Integration area/lifecycle Lifecycle management (install, uninstall, configure) related component/extensions Issues related to extension points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Meshery Server and all Components to Golang 1.23.4
3 participants