Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade meshery-operator #487

Closed
wants to merge 5 commits into from
Closed

Upgrade meshery-operator #487

wants to merge 5 commits into from

Conversation

acald-creator
Copy link
Contributor

Description

This PR updates meshery-operator to use the latest controller-runtime at v0.15.0, which uses k8s.io v0.27.

This also updates the test to utilize &client.SubResourceUpdateOptions{} instead of &client.UpdateOptions{} as this is wrapped in &client.SubResourceUpdateOptions{}

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Aisuko
Aisuko requested changes May 24, 2023
View reviewed changes
api/v1alpha1/meshsync_types_test.go
@@ -110,7 +110,9 @@ var _ = Describe("The test case for the meshsync CRDs", func() {
},
}
By("Update the status of the meshsync CRDs")
err := fakeClient.Status().Update(context, meshSync, &client.UpdateOptions{FieldManager: FileManager})
err := fakeClient.Status().Update(context, meshSync, &client.SubResourceUpdateOptions{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @acald-creator thanks for your contribution. Please check the CI issue first. I consider the test case "The meshsync CRDs update the status of the resources" is useful, I mean do we need to check the status?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aisuko I saw the CI issue, I will check to see if I can get this resolved.

@leecalcote leecalcote requested a review from Azanul May 24, 2023 02:43
@leecalcote leecalcote added area/lifecycle Lifecycle management (install, uninstall, configure) related dependencies Pull requests that update a dependency file labels May 24, 2023
leecalcote
leecalcote approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of the failing test... 👍

Azanul
Azanul approved these changes May 24, 2023
View reviewed changes
Copy link

@Azanul Azanul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (other than the failing test)

@nebula-aac
Copy link
Contributor

bump, still working on this

@nebula-aac nebula-aac self-assigned this May 28, 2023
@leecalcote
Copy link
Member

Good, good.

@stale
Copy link

stale bot commented Jul 23, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jul 23, 2023
@leecalcote leecalcote added the issue/remind Issue progress check label Jul 28, 2023
@github-actions
Copy link

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Jul 28, 2023
@leecalcote
Copy link
Member

@acald-creator @nebula-aac it'd be good to have this finished off

@nebula-aac
update unit test
7a11975 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
Copy link
Contributor

@leecalcote working on it, but still trying to get the test case to past

locally, it runs fine

@leecalcote
Copy link
Member

merge conflict

@stale
Copy link

stale bot commented Sep 24, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Sep 24, 2023
@nebula-aac
update fork
76b7e1b 
Signed-off-by: Antonette Caldwell <[email protected]>
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Sep 24, 2023
@nebula-aac
chore: Update meshkit
0fd76e6 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
chore: Update workflow to use Go 1.21
9d28acd 
Signed-off-by: Antonette Caldwell <[email protected]>
@Aisuko
Copy link
Member

Aisuko commented Oct 30, 2023

This already done by #536 , So, we close this one.

@Aisuko Aisuko closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aisuko Aisuko Aisuko requested changes

@Azanul Azanul Azanul approved these changes

@leecalcote leecalcote leecalcote approved these changes

Assignees

@nebula-aac nebula-aac

Labels
area/lifecycle Lifecycle management (install, uninstall, configure) related dependencies Pull requests that update a dependency file issue/remind Issue progress check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@acald-creator @nebula-aac @leecalcote @Aisuko @Azanul