Skip to content

fix(node): validate & sanitize node name #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(node): validate & sanitize node name #865

wants to merge 1 commit into from
+81 −8

Conversation

spacepc-de
Copy link

Fixes #798

@liamcottle
Copy link
Member

Hi there, thanks for the contribution.

It looks like this doesn't allow emojis, other language characters, and limits to ASCII only and not UTF-8?

We most certainly want to allow for emojis, but we haven't decided on what validation rules we want to impose on the node names yet.

@spacepc-de
Copy link
Author

I can change it to UTF8 if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Name input check missing
2 participants
@spacepc-de @liamcottle