Enhance Station G2 configuration to support environment sensors and G…#825
Closed
zjs81 wants to merge 2 commits into
Closed
Enhance Station G2 configuration to support environment sensors and G…#825zjs81 wants to merge 2 commits into
zjs81 wants to merge 2 commits into
Conversation
…PS. Updated platformio.ini to include sensor_base dependencies and modified target files to initialize EnvironmentSensorManager with GPS support conditionally.
Member
|
looks good |
ripplebiz
reviewed
Oct 1, 2025
| rtc_clock.begin(Wire); | ||
|
|
||
| // Initialize sensors | ||
| sensors.begin(); |
Member
There was a problem hiding this comment.
sensors.begin() is called by the various firmwares already, ie. should Not be in target.cpp
Contributor
Author
There was a problem hiding this comment.
Thanks I'll make that change this weekend.
Contributor
|
If I attach a GPS to the "GROVE GPS" port, my setup works with this: |
Member
|
this is already implemented in #922 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…PS. Updated platformio.ini to include sensor_base dependencies and modified target files to initialize EnvironmentSensorManager with GPS support conditionally.