RadioLibWrapper: Ensure correct state before processing packets to prevent IRQ ambiguity. #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViezeVingertjes
force-pushed
the
fix/prevent-irq-ambiguity
branch
3 times, most recently
from
ed652b4 to
0bace3d
Compare
ViezeVingertjes
force-pushed
the
fix/prevent-irq-ambiguity
branch
2 times, most recently
from
6b0e496 to
accc1bf
Compare
…ear IRQ state after checking for packet readiness
ViezeVingertjes
force-pushed
the
fix/prevent-irq-ambiguity
branch
from
accc1bf to
bf7a538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A shared interrupt callback set an internal flag for both RxDone and TxDone; recvRaw() treated any interrupt as RX-ready and called
readData()while not in RX.This might also be related to the LR1110's problem with the "shifted" packets but testing should confirm that before we can make that claim. Besides that problem; it might be a good improvement to implement this nonetheless, as old RadioLib issue's show that this has been an issue in the past, which we might run into sooner or later.