[pull] master from serde-rs:master by pull[bot] · Pull Request #32 · mesalock-linux/serde-sgx

pull · 2020-12-21T18:48:51Z

See Commits and Changes for more details.

Can you help keep this open source service alive? 💖 Please sponsor : )

- Check that alias is not the same as name of other field (it still can be the name of owning field/variant) - Check that aliases are unique, i. e. two different fields does not use the same alias

Implement `IntoDeserializer` for all `Deserializer`s in `serde::de::value` module

Add checks for conflicts for aliases

pacify clippy

This step has been failing way more than reasonable across my various repos. With the provided path, there will be 1 file uploaded Artifact name is valid! Root directory input is valid! Attempt 1 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 3000 ms... Attempt 2 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 6029 ms... Attempt 3 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 8270 ms... Attempt 4 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 12577 ms... Error: Failed to CreateArtifact: Failed to make request after 5 attempts: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact

Produce unreachable_patterns warning when deserialization names collide

Produce a separate warning for every colliding name

This reverts commit 951ca5a.

This reverts commit 5f9fffa.

Revert the colliding aliases hard error (PRs #2562 & #2853)

warning: this `match` expression can be replaced with `?` --> serde/build.rs:111:17 | 111 | let rustc = match env::var_os("RUSTC") { | _________________^ 112 | | Some(rustc) => rustc, 113 | | None => return None, 114 | | }; | |_____^ help: try instead: `env::var_os("RUSTC")?` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark = note: `-W clippy::question-mark` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::question_mark)]` warning: this `match` expression can be replaced with `?` --> serde/build.rs:131:16 | 131 | let next = match pieces.next() { | ________________^ 132 | | Some(next) => next, 133 | | None => return None, 134 | | }; | |_____^ help: try instead: `pieces.next()?` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark

Signed-off-by: xibeiyoumian <xibeiyoumian@outlook.com>

chore: improve code comments clarity

…ilter_map serde_derive: rewrite .iter().filter_map() with less llvm-lines

…ound_llvml serde_derive: rewrite with_bound without filter/chain/vec allocation

warning: consider adding a `;` to the last statement for consistent formatting --> serde_derive/src/pretend.rs:124:17 | 124 | patterns.push(quote!(#type_ident::#variant_ident { #(#members: #placeholders),* })) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `patterns.push(quote!(#type_ident::#variant_ident { #(#members: #placeholders),* }));` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned = note: `-W clippy::semicolon-if-nothing-returned` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::semicolon_if_nothing_returned)]`

typo: tokenenizable to tokenizable

…er_enumerate serde_derive: rewrite fields_from_ast with less llvm-lines

serde_derive: reduce llvm-lines in ser.rs, reuse fn field_i

warning: redundant closure --> serde_derive/src/ser.rs:461:65 | 461 | let field_names = (0..variant.fields.len()).map(|i| field_i(i)); | ^^^^^^^^^^^^^^ help: replace the closure with the function itself: `field_i` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `-W clippy::redundant-closure` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::redundant_closure)]`

warning: feature `never_type` is declared but not used --> serde/src/lib.rs:108:43 | 108 | #![cfg_attr(feature = "unstable", feature(never_type))] | ^^^^^^^^^^ | = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default

warning: borrow of a mutable reference --> serde_core/src/de/impls.rs:1054:32 | 1054 | $clear(&mut self.0); | ^^^^^ ... 1076 | / seq_impl!( 1077 | | #[cfg(any(feature = "std", feature = "alloc"))] 1078 | | #[cfg_attr(docsrs, doc(cfg(any(feature = "std", feature = "alloc"))))] 1079 | | BinaryHeap<T: Ord>, ... | 1084 | | BinaryHeap::push 1085 | | ); | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut = note: `-W clippy::mut-mut` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::mut_mut)]` = note: this warning originates in the macro `seq_impl` (in Nightly builds, run with -Z macro-backtrace for more info) help: reborrow instead | 1054 | $clear(&mut *self.0); | + warning: borrow of a mutable reference --> serde_core/src/de/impls.rs:1055:34 | 1055 | $reserve(&mut self.0, size_hint::cautious::<T>($access.size_hint())); | ^^^^^ ... 1076 | / seq_impl!( 1077 | | #[cfg(any(feature = "std", feature = "alloc"))] 1078 | | #[cfg_attr(docsrs, doc(cfg(any(feature = "std", feature = "alloc"))))] 1079 | | BinaryHeap<T: Ord>, ... | 1084 | | BinaryHeap::push 1085 | | ); | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut = note: this warning originates in the macro `seq_impl` (in Nightly builds, run with -Z macro-backtrace for more info) help: reborrow instead | 1055 | $reserve(&mut *self.0, size_hint::cautious::<T>($access.size_hint())); | + warning: borrow of a mutable reference --> serde_core/src/de/impls.rs:1059:37 | 1059 | $insert(&mut self.0, value); | ^^^^^ ... 1076 | / seq_impl!( 1077 | | #[cfg(any(feature = "std", feature = "alloc"))] 1078 | | #[cfg_attr(docsrs, doc(cfg(any(feature = "std", feature = "alloc"))))] 1079 | | BinaryHeap<T: Ord>, ... | 1084 | | BinaryHeap::push 1085 | | ); | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut = note: this warning originates in the macro `seq_impl` (in Nightly builds, run with -Z macro-backtrace for more info) help: reborrow instead | 1059 | $insert(&mut *self.0, value); | + warning: borrow of a mutable reference --> serde_core/src/de/impls.rs:1054:32 | 1054 | $clear(&mut self.0); | ^^^^^ ... 1087 | / seq_impl!( 1088 | | #[cfg(any(feature = "std", feature = "alloc"))] 1089 | | #[cfg_attr(docsrs, doc(cfg(any(feature = "std", feature = "alloc"))))] 1090 | | BTreeSet<T: Eq + Ord>, ... | 1095 | | BTreeSet::insert 1096 | | ); | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut = note: this warning originates in the macro `seq_impl` (in Nightly builds, run with -Z macro-backtrace for more info) help: reborrow instead | 1054 | $clear(&mut *self.0); | + warning: borrow of a mutable reference --> serde_core/src/de/impls.rs:1055:34 | 1055 | $reserve(&mut self.0, size_hint::cautious::<T>($access.size_hint())); | ^^^^^ ... 1087 | / seq_impl!( 1088 | | #[cfg(any(feature = "std", feature = "alloc"))] 1089 | | #[cfg_attr(docsrs, doc(cfg(any(feature = "std", feature = "alloc"))))] 1090 | | BTreeSet<T: Eq + Ord>, ... | 1095 | | BTreeSet::insert 1096 | | ); | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut = note: this warning originates in the macro `seq_impl` (in Nightly builds, run with -Z macro-backtrace for more info) help: reborrow instead | 1055 | $reserve(&mut *self.0, size_hint::cautious::<T>($access.size_hint())); | + warning: borrow of a mutable reference --> serde_core/src/de/impls.rs:1059:37 | 1059 | $insert(&mut self.0, value); | ^^^^^ ... 1087 | / seq_impl!( 1088 | | #[cfg(any(feature = "std", feature = "alloc"))] 1089 | | #[cfg_attr(docsrs, doc(cfg(any(feature = "std", feature = "alloc"))))] 1090 | | BTreeSet<T: Eq + Ord>, ... | 1095 | | BTreeSet::insert 1096 | | ); | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut = note: this warning originates in the macro `seq_impl` (in Nightly builds, run with -Z macro-backtrace for more info) help: reborrow instead | 1059 | $insert(&mut *self.0, value); | + warning: borrow of a mutable reference --> serde_core/src/de/impls.rs:1054:32 | 1054 | $clear(&mut self.0); | ^^^^^ ... 1098 | / seq_impl!( 1099 | | #[cfg(any(feature = "std", feature = "alloc"))] 1100 | | #[cfg_attr(docsrs, doc(cfg(any(feature = "std", feature = "alloc"))))] 1101 | | LinkedList<T>, ... | 1106 | | LinkedList::push_back 1107 | | ); | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut = note: this warning originates in the macro `seq_impl` (in Nightly builds, run with -Z macro-backtrace for more info) help: reborrow instead | 1054 | $clear(&mut *self.0); | + warning: borrow of a mutable reference --> serde_core/src/de/impls.rs:1055:34 | 1055 | $reserve(&mut self.0, size_hint::cautious::<T>($access.size_hint())); | ^^^^^ ... 1098 | / seq_impl!( 1099 | | #[cfg(any(feature = "std", feature = "alloc"))] 1100 | | #[cfg_attr(docsrs, doc(cfg(any(feature = "std", feature = "alloc"))))] 1101 | | LinkedList<T>, ... | 1106 | | LinkedList::push_back 1107 | | ); | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut = note: this warning originates in the macro `seq_impl` (in Nightly builds, run with -Z macro-backtrace for more info) help: reborrow instead | 1055 | $reserve(&mut *self.0, size_hint::cautious::<T>($access.size_hint())); | + warning: borrow of a mutable reference --> serde_core/src/de/impls.rs:1059:37 | 1059 | $insert(&mut self.0, value); | ^^^^^ ... 1098 | / seq_impl!( 1099 | | #[cfg(any(feature = "std", feature = "alloc"))] 1100 | | #[cfg_attr(docsrs, doc(cfg(any(feature = "std", feature = "alloc"))))] 1101 | | LinkedList<T>, ... | 1106 | | LinkedList::push_back 1107 | | ); | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut = note: this warning originates in the macro `seq_impl` (in Nightly builds, run with -Z macro-backtrace for more info) help: reborrow instead | 1059 | $insert(&mut *self.0, value); | + warning: borrow of a mutable reference --> serde_core/src/de/impls.rs:1054:32 | 1054 | $clear(&mut self.0); | ^^^^^ ... 1109 | / seq_impl!( 1110 | | #[cfg(feature = "std")] 1111 | | #[cfg_attr(docsrs, doc(cfg(feature = "std")))] 1112 | | HashSet<T: Eq + Hash, S: BuildHasher + Default>, ... | 1117 | | HashSet::insert 1118 | | ); | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut = note: this warning originates in the macro `seq_impl` (in Nightly builds, run with -Z macro-backtrace for more info) help: reborrow instead | 1054 | $clear(&mut *self.0); | + warning: borrow of a mutable reference --> serde_core/src/de/impls.rs:1055:34 | 1055 | $reserve(&mut self.0, size_hint::cautious::<T>($access.size_hint())); | ^^^^^ ... 1109 | / seq_impl!( 1110 | | #[cfg(feature = "std")] 1111 | | #[cfg_attr(docsrs, doc(cfg(feature = "std")))] 1112 | | HashSet<T: Eq + Hash, S: BuildHasher + Default>, ... | 1117 | | HashSet::insert 1118 | | ); | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut = note: this warning originates in the macro `seq_impl` (in Nightly builds, run with -Z macro-backtrace for more info) help: reborrow instead | 1055 | $reserve(&mut *self.0, size_hint::cautious::<T>($access.size_hint())); | + warning: borrow of a mutable reference --> serde_core/src/de/impls.rs:1059:37 | 1059 | $insert(&mut self.0, value); | ^^^^^ ... 1109 | / seq_impl!( 1110 | | #[cfg(feature = "std")] 1111 | | #[cfg_attr(docsrs, doc(cfg(feature = "std")))] 1112 | | HashSet<T: Eq + Hash, S: BuildHasher + Default>, ... | 1117 | | HashSet::insert 1118 | | ); | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut = note: this warning originates in the macro `seq_impl` (in Nightly builds, run with -Z macro-backtrace for more info) help: reborrow instead | 1059 | $insert(&mut *self.0, value); | + warning: borrow of a mutable reference --> serde_core/src/de/impls.rs:1054:32 | 1054 | $clear(&mut self.0); | ^^^^^ ... 1120 | / seq_impl!( 1121 | | #[cfg(any(feature = "std", feature = "alloc"))] 1122 | | #[cfg_attr(docsrs, doc(cfg(any(feature = "std", feature = "alloc"))))] 1123 | | VecDeque<T>, ... | 1128 | | VecDeque::push_back 1129 | | ); | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut = note: this warning originates in the macro `seq_impl` (in Nightly builds, run with -Z macro-backtrace for more info) help: reborrow instead | 1054 | $clear(&mut *self.0); | + warning: borrow of a mutable reference --> serde_core/src/de/impls.rs:1055:34 | 1055 | $reserve(&mut self.0, size_hint::cautious::<T>($access.size_hint())); | ^^^^^ ... 1120 | / seq_impl!( 1121 | | #[cfg(any(feature = "std", feature = "alloc"))] 1122 | | #[cfg_attr(docsrs, doc(cfg(any(feature = "std", feature = "alloc"))))] 1123 | | VecDeque<T>, ... | 1128 | | VecDeque::push_back 1129 | | ); | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut = note: this warning originates in the macro `seq_impl` (in Nightly builds, run with -Z macro-backtrace for more info) help: reborrow instead | 1055 | $reserve(&mut *self.0, size_hint::cautious::<T>($access.size_hint())); | + warning: borrow of a mutable reference --> serde_core/src/de/impls.rs:1059:37 | 1059 | $insert(&mut self.0, value); | ^^^^^ ... 1120 | / seq_impl!( 1121 | | #[cfg(any(feature = "std", feature = "alloc"))] 1122 | | #[cfg_attr(docsrs, doc(cfg(any(feature = "std", feature = "alloc"))))] 1123 | | VecDeque<T>, ... | 1128 | | VecDeque::push_back 1129 | | ); | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_mut = note: this warning originates in the macro `seq_impl` (in Nightly builds, run with -Z macro-backtrace for more info) help: reborrow instead | 1059 | $insert(&mut *self.0, value); | +

Update to syn 3

pull Bot added the ⤵️ pull label Dec 21, 2020

pull Bot added the merge-conflict Resolve conflicts manually label Jan 11, 2021

dtolnay force-pushed the master branch from cadc3de to e9270e5 Compare March 27, 2021 03:29

dtolnay force-pushed the master branch from ab4666e to f309485 Compare August 17, 2021 02:33

dtolnay force-pushed the master branch from 87444c3 to 69240c1 Compare January 21, 2022 04:37

dtolnay force-pushed the master branch from 9ec660a to 31e5132 Compare June 6, 2022 23:09

dtolnay force-pushed the master branch 2 times, most recently from 58c82f1 to d208762 Compare September 3, 2022 04:16

Mingun and others added 22 commits October 25, 2024 19:18

Add checks for conflicts for aliases

5f9fffa

- Check that alias is not the same as name of other field (it still can be the name of owning field/variant) - Check that aliases are unique, i. e. two different fields does not use the same alias

Merge pull request #2568 from Mingun/into_deserializer-for-deserializers

210373b

Implement `IntoDeserializer` for all `Deserializer`s in `serde::de::value` module

Release 1.0.214

4180621

Merge pull request #2562 from Mingun/alias-check

adf05a5

Add checks for conflicts for aliases

pacify clippy

951ca5a

Merge pull request #2853 from serde-rs/oli-obk-patch-1

a95b0d3

pacify clippy

Rename Name -> MultiName

3035d4f

Move MultiName to a new module

f0b5c4f

Keep track of a span for alias strings

373edcd

Merge pull request #2855 from dtolnay/namespan

7f1e697

Produce unreachable_patterns warning when deserialization names collide

Produce a separate warning for every colliding name

c59e876

Merge pull request #2856 from dtolnay/dename

b1353a9

Produce a separate warning for every colliding name

Revert "pacify clippy"

a20e924

This reverts commit 951ca5a.

Revert "Add checks for conflicts for aliases"

edd6fe9

This reverts commit 5f9fffa.

Update ui tests for warning on colliding aliases

111ecc5

Merge pull request #2857 from dtolnay/collide

7d96352

Revert the colliding aliases hard error (PRs #2562 & #2853)

Update PR 2562 ui tests

1a3cf4b

Use ui test syntax that does not interfere with rustfmt

fa5d58c

Release 1.0.215

8939af4

Use BuildHasher instead of Hasher in collection macros

c270e27

dtolnay and others added 30 commits November 20, 2025 10:19

Update actions/checkout@v4 -> v5

1c396d2

Update actions/checkout@v5 -> v6

f7fc3e0

Update actions/upload-artifact@v4 -> v5

dd0eb0f

Update actions/upload-artifact@v5 -> v6

576e2ef

chore: improve code comments clarity

a27948e

Signed-off-by: xibeiyoumian <xibeiyoumian@outlook.com>

Merge pull request #3019 from xibeiyoumian/master

d179020

chore: improve code comments clarity

Raise required compiler for serde_derive to Rust 1.71

681270e

serde_derive: rewrite .iter().filter_map() with less llvm-lines

2c6d0d2

serde_derive: rewrite with_bound without filter/chain/vec allocation

bfc9ccf

Merge pull request #3034 from dishmaker/dishmaker/serde_derive_less_f…

888de67

…ilter_map serde_derive: rewrite .iter().filter_map() with less llvm-lines

Merge pull request #3035 from dishmaker/dishmaker/serde_derive_with_b…

3587aed

…ound_llvml serde_derive: rewrite with_bound without filter/chain/vec allocation

serde_derive: rewrite fields_from_ast with less llvm-lines

1229fc8

serde_derive: reduce llvm-lines in ser.rs, reuse fn field_i

098da70

serde_derive: rewrite serialize_struct_visitor

ea04847

typo: tokenenizable tokenizable

7d8427c

Merge pull request #3039 from cuiweixie/typo

7893347

typo: tokenenizable to tokenizable

Merge pull request #3037 from dishmaker/dishmaker/serde_derive_ast_it…

9d17f29

…er_enumerate serde_derive: rewrite fields_from_ast with less llvm-lines

Merge pull request #3038 from dishmaker/dishmaker/serde_derive_field_i

e65b3e7

serde_derive: reduce llvm-lines in ser.rs, reuse fn field_i

Unpin CI miri toolchain

6b1a178

Fix unused_features warning

fa7da4a

warning: feature `never_type` is declared but not used --> serde/src/lib.rs:108:43 | 108 | #![cfg_attr(feature = "unstable", feature(never_type))] | ^^^^^^^^^^ | = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default

Regenerate stderr with trybuild normalization fixes

63a1498

Update ui test suite to nightly-2026-06-01

5f0f18b

Update actions/checkout@v6 -> v7

dd682c2

Update actions/upload-artifact@v6 -> v7

1023d07

Update to syn 3

6dec3b7

Merge pull request #3085 from dtolnay/syn3

6d6e9a1

Update to syn 3

Release 1.0.229

7fc3b4c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[pull] master from serde-rs:master#32

[pull] master from serde-rs:master#32
pull[bot] wants to merge 1304 commits into
mesalock-linux:masterfrom
serde-rs:master

pull Bot commented Dec 21, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Uh oh!

Conversation

pull Bot commented Dec 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

pull Bot commented Dec 21, 2020 •

edited

Loading