[pull] master from serde-rs:master #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
The other as_* methods all come after the corresponding is_* method.
warning: redundant explicit link target
--> src/lib.rs:59:20
|
59 | //! [`from_slice`][from_slice] for parsing from a byte slice &[u8] and
| ------------ ^^^^^^^^^^ explicit target is redundant
| |
| because label contains path that resolves to same destination
|
note: referenced explicit link target defined here
--> src/lib.rs:295:19
|
295 | //! [from_slice]: crate::de::from_slice
| ^^^^^^^^^^^^^^^^^^^^^
= note: when a link's destination is not specified,
the label is used to resolve intra-doc links
= note: `#[warn(rustdoc::redundant_explicit_links)]` on by default
help: remove explicit link target
|
59 | //! [`from_slice`] for parsing from a byte slice &[u8] and
| ~~~~~~~~~~~~~~
warning: redundant explicit link target
--> src/lib.rs:60:21
|
60 | //! [`from_reader`][from_reader] for parsing from any `io::Read` like a File or
| ------------- ^^^^^^^^^^^ explicit target is redundant
| |
| because label contains path that resolves to same destination
|
note: referenced explicit link target defined here
--> src/lib.rs:296:20
|
296 | //! [from_reader]: crate::de::from_reader
| ^^^^^^^^^^^^^^^^^^^^^^
= note: when a link's destination is not specified,
the label is used to resolve intra-doc links
help: remove explicit link target
|
60 | //! [`from_reader`] for parsing from any `io::Read` like a File or
| ~~~~~~~~~~~~~~~
adds `as_str` to `Number` if `arbitrary_precision` is enabled
This reverts commit c754f03.
Co-authored-by: David Tolnay <[email protected]>
Simplify/remove build.rs following the bump to 2021 edition
Support deserializing from &RawValue
IntoDeserializer for &RawValue
Remove a few unnecessary lifetimes
warning: unused imports: `parse_concise_float`, `parse_truncated_float`
--> tests/../src/lexical/mod.rs:38:23
|
38 | pub use self::parse::{parse_concise_float, parse_truncated_float};
| ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
warning: unused import: `std::vec::Vec`
--> tests/lexical.rs:30:13
|
30 | pub use std::vec::Vec;
| ^^^^^^^^^^^^^
warning: unused imports: `cmp`, `iter`, `mem`, `ops`
--> tests/lexical.rs:31:19
|
31 | pub use std::{cmp, iter, mem, ops};
| ^^^ ^^^^ ^^^ ^^^
Add test of negative NaN and negative infinity
Implement From<[T; N]> for Value
…nd-bools Add literal 'null', 'true' and 'false' consts to `RawValue` struct.
Move RawValue associated constants into same impl block as public functions
warning: operator precedence can trip the unwary
--> src/read.rs:963:18
|
963 | let n = (((n1 - 0xD800) as u32) << 10 | (n2 - 0xDC00) as u32) + 0x1_0000;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(((n1 - 0xD800) as u32) << 10) | (n2 - 0xDC00) as u32`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
= note: `-W clippy::precedence` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::precedence)]`
warning: operator precedence can trip the unwary
--> src/read.rs:991:28
|
991 | ptr.write((n >> 6 & 0b0001_1111) as u8 | 0b1100_0000);
| ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(n >> 6) & 0b0001_1111`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
warning: operator precedence can trip the unwary
--> src/read.rs:995:28
|
995 | ptr.write((n >> 12 & 0b0000_1111) as u8 | 0b1110_0000);
| ^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(n >> 12) & 0b0000_1111`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
warning: operator precedence can trip the unwary
--> src/read.rs:996:35
|
996 | ptr.add(1).write((n >> 6 & 0b0011_1111) as u8 | 0b1000_0000);
| ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(n >> 6) & 0b0011_1111`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
warning: operator precedence can trip the unwary
--> src/read.rs:1000:28
|
1000 | ptr.write((n >> 18 & 0b0000_0111) as u8 | 0b1111_0000);
| ^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(n >> 18) & 0b0000_0111`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
warning: operator precedence can trip the unwary
--> src/read.rs:1002:29
|
1002 | .write((n >> 12 & 0b0011_1111) as u8 | 0b1000_0000);
| ^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(n >> 12) & 0b0011_1111`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
warning: operator precedence can trip the unwary
--> src/read.rs:1003:35
|
1003 | ptr.add(2).write((n >> 6 & 0b0011_1111) as u8 | 0b1000_0000);
| ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(n >> 6) & 0b0011_1111`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
Signed-off-by: tison <[email protected]>
Add Map::into_values method
Use Map::with_capacity in value::Serializer::serialize_map
Enable "float_roundtrip" and "unbounded_depth" features in playground
Cargo stopped generating this in its project template 5 years ago. It would belong in a global gitignore instead.
This belongs in someone's global gitignore.
Improve documentation for buffering around functions taking a reader
The original read_user_from_stream function from PR 1237 is a bad pattern because it results in silently dropping any data left in the buffer on return. If we want to read anything else from the same TcpStream after the JSON object, the buffer needs to go in the caller.
warning: unnecessary semicolon
--> src/de.rs:371:10
|
371 | };
| ^ help: remove
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon
= note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]`
False is the default value since Cargo PR 11499.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )