Skip to content

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 27, 2020

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label Jan 27, 2020
@pull pull bot added the merge-conflict Resolve conflicts manually label Feb 19, 2020
Nil Goyette and others added 28 commits June 15, 2023 13:43
Update README-quick-start.md
Updated Windows `base` Computations to be Safer
The existing documentation states that the behavior of slicing is the same as
in NumPy except when `step < -1`, implying that the behavior is the same when
`step = -1`. But this is not true:

In [1]: import numpy as np

In [2]: x = np.arange(10)

In [3]: x[2 : 5 : -1]  # Analogous slice in `ndarray`: `array![4, 3, 2]`
Out[3]: array([], dtype=int32)

In [4]: x[5 : 2 : -1]  # Analogous slice in `ndarray`: `array![]`
Out[4]: array([5, 4, 3])

So `step < -1` should be replaced by `step < 0` in the documentation.

There are some further differences in slicing behavior with negative step,
having to do with the default values for `start` and `end`:

In [5]: x[: 7 : -1]  # Analogous slice in `ndarray`: `array![6, 5, 4, 3, 2, 1, 0]`
Out[5]: array([9, 8])

In [6]: x[7 : : -1]  # Analogous slice in `ndarray`: `array![9, 8, 7]`
Out[6]: array([7, 6, 5, 4, 3, 2, 1, 0])
Fix comparison with NumPy of slicing with negative step
In `fill()` and in `assign()`.
Co-authored-by: Adam Reichold <[email protected]>
When an array has 0 or 1 elements, strides don't matter anymore. The
general case of this function handled this correctly, but the special
case for ndim == 1 did not.
akern40 and others added 30 commits March 17, 2025 20:44
Uses the implementations from `Array1` and `Array2`, tests found in `crates/blas-tests/tests/dyn.rs`.
See #1440 for more information, especially [this comment](#1440 (comment)).
Also runs latest-deps CI when someone changes the latest-deps.yaml configuration
Adds a Numpy-equivalent `meshgrid` function
Also adds an accelerate option to the blas-tests crate
* add test case for empty array

* return early when the array has zero lenth dims

---------

Co-authored-by: Adam Kern <[email protected]>
* draft for inplace reverse, permute

* add test cases

* formatter

* cycle detection logic with bitmask

* formatter

* satisfying CI(cargo doc, etc.)

* add comments from doc, to describe how the logic works
These allow the iterators to act on the lifetime of the data, not the lifetime of the view.
Specifically, deals with CVE-2025-4574, GHSA-4fcv-w3qc-ppgg, and GHSA-255r-3prx-mf99 by updating the lockfile and one set of dependencies for testing serialization.
Simple update, just an edition change in Cargo.toml and a run of `cargo update` with an MSRV-aware resolver.
* Fixes some broken references in the docs

* Raise allowable epsilon errors on logspace and geomspace

For some reason, when Miri runs, we get higher floating point error on these methods.
Also, remove the `if: always()` on the conclusion step of CI so that it doesn't pop up when we just change the `latest-deps.yaml`.
ndarray-rand crate on the main branch uses the workspace rand and
rand_distr versions, which are 0.9 and 0.5 respectively. This commit
documents those versions at ndarray-rand's lib.rs' module level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⤵️ pull merge-conflict Resolve conflicts manually

Projects

None yet

Development

Successfully merging this pull request may close these issues.