Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add networking/traceroute #48

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add networking/traceroute #48

wants to merge 4 commits into from

Conversation

Arcterus
Copy link
Contributor

TCP and IPv6 support still need to be added (AFAICT my ISP doesn't support IPv6 so I can't really test it even if I added support). TCP was giving me issues so I have decided to shelve it for now (we can probably just open an issue so someone can come along and work on it later).

There are some FIXMEs and such still in the code that I haven't yet gotten around to fixing. Several are regarding output formatting (like what to do when the first connection times out by the second connection attempt to the same hop succeeds), but one or two involve malformed packets.

@codecov
Copy link

codecov bot commented Oct 22, 2018

Codecov Report

Merging #48 into master will decrease coverage by 0.41%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   19.73%   19.32%   -0.42%     
==========================================
  Files          46       47       +1     
  Lines        4677     4912     +235     
  Branches     1083     1158      +75     
==========================================
+ Hits          923      949      +26     
- Misses       3367     3565     +198     
- Partials      387      398      +11
Impacted Files Coverage Δ
libmesabox/src/lib.rs 59.01% <ø> (ø) ⬆️
libmesabox/src/networking/traceroute.rs 0% <0%> (ø)
libmesabox/src/util/platform/unix.rs 0% <0%> (ø) ⬆️
libmesabox/src/posix/sh/parser.rs 0% <0%> (ø) ⬆️
libmesabox/src/networking/ping/mod.rs 0% <0%> (ø) ⬆️
libmesabox/src/lsb/tar/mod.rs 0% <0%> (ø) ⬆️
libmesabox/src/posix/chmod.rs 24.11% <0%> (+0.14%) ⬆️
libmesabox/src/util/mod.rs 53.68% <0%> (+0.49%) ⬆️
libmesabox/src/posix/sh/mod.rs 32.28% <0%> (+0.74%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30be44a...2e32c99. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant