Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: flowchart-elk e2e test #6102 #6103

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kairi003
Copy link
Contributor

@kairi003 kairi003 commented Dec 1, 2024

📑 Summary

Fix e2e test for flowchart-elk.

Resolves #6102

📏 Design Decisions

  • change maxWidthValue range for "7-elk" and "8-elk".
  • change svg.querySelectorAll to svg[0].querySelectorAll because of type errror.
  • change ` to " in mermaid text for "Wrapping long text with a new line", because back quote is invalid syntax.
  • rename duplicate test name: "Sub graphs and markdown strings".

Changing the expectation instead of the implementation could break compatibility, but in this case, I believe it’s fine.

This is because the changed part was enabled when CI was stopped, so it hadn’t been tested before.

To explain further, describe('Flowchart ELK') was describe.skip('Flowchart ELK') until 0dff4ca. When this commit was merged, the e2e tests weren’t running due to API rate limits.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features. unnecessary
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:. unnecessary

Copy link

changeset-bot bot commented Dec 1, 2024

⚠️ No Changeset found

Latest commit: 798f53f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Dec 1, 2024
Copy link

netlify bot commented Dec 1, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 798f53f
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/674bd95b7abdd30008403941
😎 Deploy Preview https://deploy-preview-6103--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Dec 1, 2024

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6103
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6103
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6103
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6103

commit: 798f53f

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.48%. Comparing base (df636c6) to head (798f53f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6103   +/-   ##
=======================================
  Coverage     4.48%   4.48%           
=======================================
  Files          383     382    -1     
  Lines        54038   54027   -11     
  Branches       596     621   +25     
=======================================
  Hits          2425    2425           
+ Misses       51613   51602   -11     
Flag Coverage Δ
unit 4.48% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link

argos-ci bot commented Dec 1, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 9 changed, 60 added Dec 1, 2024, 3:44 AM

@kairi003 kairi003 changed the title Fix: flowchart-elk e2e test Fix: flowchart-elk e2e test #6102 Dec 1, 2024
@kairi003
Copy link
Contributor Author

kairi003 commented Dec 1, 2024

Hi @ashishjain0512,

I fixed a failing test case for flowchart-elk.
Could you please take a look when you have time?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e test for flowchart-elk is broken in @mermaid-js/[email protected]
1 participant