-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: flowchart-elk e2e test #6102 #6103
base: develop
Are you sure you want to change the base?
Fix: flowchart-elk e2e test #6102 #6103
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6103 +/- ##
=======================================
Coverage 4.48% 4.48%
=======================================
Files 383 382 -1
Lines 54038 54027 -11
Branches 596 621 +25
=======================================
Hits 2425 2425
+ Misses 51613 51602 -11
Flags with carried forward coverage won't be shown. Click here to find out more. |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Hi @ashishjain0512, I fixed a failing test case for flowchart-elk. Thank you! |
📑 Summary
Fix e2e test for flowchart-elk.
Resolves #6102
📏 Design Decisions
svg.querySelectorAll
tosvg[0].querySelectorAll
because of type errror.`
to"
in mermaid text for "Wrapping long text with a new line", because back quote is invalid syntax.Changing the expectation instead of the implementation could break compatibility, but in this case, I believe it’s fine.
This is because the changed part was enabled when CI was stopped, so it hadn’t been tested before.
To explain further,
describe('Flowchart ELK')
wasdescribe.skip('Flowchart ELK')
until 0dff4ca. When this commit was merged, the e2e tests weren’t running due to API rate limits.📋 Tasks
Make sure you
📓 have added documentation. Make sureunnecessaryMERMAID_RELEASE_VERSION
is used for all new features.🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by runningunnecessarypnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.