Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge back master to develop #6092

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Merge back master to develop #6092

merged 6 commits into from
Nov 27, 2024

Conversation

ashishjain0512
Copy link
Collaborator

📑 Summary

This pull request introduces several updates and fixes, primarily focusing on improving the handling of diamond shape intersections in flowcharts and updating the mermaid-layout-elk package. The changes include new test cases for diamond shape intersections, updates to the mermaid-layout-elk package version, and adjustments to the rendering logic for diamond shapes.

Improvements to flowchart rendering:

Updates to mermaid-layout-elk package:

Adjustments to rendering logic:

Minor HTML updates:

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: becadf0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit becadf0
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/674755759651000008b8e59c
😎 Deploy Preview https://deploy-preview-6092--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 27, 2024

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6092
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6092
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6092
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6092

commit: becadf0

@ashishjain0512 ashishjain0512 merged commit 64554a6 into develop Nov 27, 2024
23 of 29 checks passed
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 4.48%. Comparing base (b4879d1) to head (becadf0).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
packages/mermaid-layout-elk/src/render.ts 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6092      +/-   ##
==========================================
- Coverage     4.49%   4.48%   -0.01%     
==========================================
  Files          383     382       -1     
  Lines        53925   54027     +102     
  Branches       596     621      +25     
==========================================
  Hits          2425    2425              
- Misses       51500   51602     +102     
Flag Coverage Δ
unit 4.48% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid-layout-elk/src/render.ts 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants