Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:6088 fix for diamond intersections #6089

Closed
wants to merge 15 commits into from

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Nov 27, 2024

📑 Summary

Updated offset calculations for diamond shape when handling intersections

Resolves #6088

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: c8e5027

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@mermaid-js/layout-elk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit c8e5027
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/674732e0a66b61000883dc14
😎 Deploy Preview https://deploy-preview-6089--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 27, 2024

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6089
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6089
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6089
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6089

commit: c8e5027

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 153 lines in your changes missing coverage. Please review.

Project coverage is 4.48%. Comparing base (f471333) to head (c8e5027).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
.../src/diagrams/architecture/architectureRenderer.ts 0.00% 85 Missing ⚠️
...aid/src/diagrams/architecture/architectureTypes.ts 0.00% 32 Missing ⚠️
...ermaid/src/diagrams/architecture/architectureDb.ts 0.00% 24 Missing ⚠️
packages/mermaid-layout-elk/src/render.ts 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6089      +/-   ##
=========================================
- Coverage    4.49%   4.48%   -0.01%     
=========================================
  Files         383     382       -1     
  Lines       53925   54027     +102     
  Branches      596     621      +25     
=========================================
  Hits         2425    2425              
- Misses      51500   51602     +102     
Flag Coverage Δ
unit 4.48% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid-layout-elk/src/render.ts 0.00% <0.00%> (ø)
...ermaid/src/diagrams/architecture/architectureDb.ts 0.00% <0.00%> (ø)
...aid/src/diagrams/architecture/architectureTypes.ts 0.00% <0.00%> (ø)
.../src/diagrams/architecture/architectureRenderer.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@knsv knsv changed the base branch from develop to master November 27, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

At some occations the intersection calculations for diamond shapes fail when using elk
6 participants