Allow architecture diagrams to support any character for titles

[wizbit]

📑 Summary

Allows any character between [ and ] for architecture diagram titles.

Resolves #5928

📏 Design Decisions

Change of regex to allow any character. Also had to tweak the entry Architecture rule as tests were claiming ambiguity.

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added necessary unit/e2e tests.
• 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
• 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 67d928f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	67d928f
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/673b048ef7b09c0008224903
😎 Deploy Preview	https://deploy-preview-5929--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@5929

pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@5929

pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@5929

pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@5929

commit: 67d928f

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 4.49%. Comparing base (8328f74) to head (67d928f).

Files with missing lines	Patch %	Lines
packages/parser/tests/test-util.ts	0.00%	14 Missing ⚠️
...parser/src/language/architecture/valueConverter.ts	0.00%	12 Missing ⚠️
...mermaid/src/rendering-util/handle-markdown-text.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #5929      +/-   ##
==========================================
- Coverage     4.49%   4.49%   -0.01%     
==========================================
  Files          382     383       +1     
  Lines        53914   53952      +38     
  Branches       621     596      -25     
==========================================
  Hits          2425    2425              
- Misses       51489   51527      +38     

Flag	Coverage Δ
unit	4.49% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...mermaid/src/rendering-util/handle-markdown-text.ts	0.00% <0.00%> (ø)
...parser/src/language/architecture/valueConverter.ts	0.00% <0.00%> (ø)
packages/parser/tests/test-util.ts	0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

[sidharthv96]

Allowing all characters seems okay at the first glance. Love the unit tests!
We should unify the string handling approach, and support markdown as well. (We already support it in flowcharts and some others, so the same functions should be used).

---

We should also make the grammar stricter to disallow architecture-beta and group in the same line. As the grammar is in beta, we can make breaking changes.

---

After this is finalized, we also need E2E tests and documentation updates, which show the capabilities in examples.

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Waiting for the first build to start…

[NicolasNewman]

Good catch on the ambiguous grammar! If markdown support is planned to be added we may also want to consider KaTeX support. Other then the above request changes everything looks good to me.

[wizbit]

Added markdown support. It already had the ability to render, so added grammar rules for ["`...`"]and ["..."].
KaTeX support is tricker. I've added it to the demos but it does not render correctly. Turning on htmlLabels for rendering makes it work but breaks everything else, so not sure how to proceed with KaTeX.