Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: trigger validators on issue_comment #766

Merged
merged 2 commits into from
Jul 29, 2024
Merged

feat: trigger validators on issue_comment #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad595dd
trigger validators on issue_comment
andekande Jul 10, 2024
5037d53
Merge branch 'master' into enable-issue-comment-in-validators
shine2lay Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
CHANGELOG
=====================================
| July 10, 2024: feat: Add trigger 'issue_comment' in validators `age`, `assignee`, `author`, `description`, `label`, `title` `#766 <https://github.com/mergeability/mergeable/pull/766>`_
| June 25 2024: feat: Add buildpacks for building docker image `#764 <https://github.com/mergeability/mergeable/pull/764>`_
| June 20, 2024: feat: Add options 'one_of' and 'none_of'. Support in filters `payload`, `author`, and in action `lastComment` to filter comments authors `#757 <https://github.com/mergeability/mergeable/pull/757>`_
| June 20, 2024: feat: Add annotations @sender @bot @repository @action and template helper {{formatDate}} `#756 <https://github.com/mergeability/mergeable/pull/756>`_
Expand Down
2 changes: 1 addition & 1 deletion docs/validators/age.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ Age
Supported Events:
::

'pull_request.*', 'pull_request_review.*',
'pull_request.*', 'pull_request_review.*', 'issue_comment.*'
2 changes: 1 addition & 1 deletion docs/validators/assignee.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ Assignee
Supported Events:
::

'pull_request.*', 'pull_request_review.*', 'issues.*'
'pull_request.*', 'pull_request_review.*', 'issues.*', 'issue_comment.*'

2 changes: 1 addition & 1 deletion docs/validators/author.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,4 @@ you can also nest ``and`` and ``or`` options
Supported Events:
::

'pull_request.*', 'pull_request_review.*'
'pull_request.*', 'pull_request_review.*', 'issues.*', 'issue_comment.*'
2 changes: 1 addition & 1 deletion docs/validators/description.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,4 @@ you can also nest ``and`` and ``or`` options
Supported Events:
::

'pull_request.*', 'pull_request_review.*', 'issues.*'
'pull_request.*', 'pull_request_review.*', 'issues.*', 'issue_comment.*'
2 changes: 1 addition & 1 deletion docs/validators/label.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,4 @@ you can also nest ``and`` and ``or`` options
Supported Events:
::

'pull_request.*', 'pull_request_review.*', 'issues.*'
'pull_request.*', 'pull_request_review.*', 'issues.*', 'issue_comment.*'
2 changes: 1 addition & 1 deletion docs/validators/title.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,4 @@ you can also nest ``and`` and ``or`` options
Supported Events:
::

'pull_request.*', 'pull_request_review.*', 'issues.*'
'pull_request.*', 'pull_request_review.*', 'issues.*', 'issue_comment.*'
3 changes: 2 additions & 1 deletion lib/validators/age.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ class Age extends Validator {
super('time')
this.supportedEvents = [
'pull_request.*',
'pull_request_review.*'
'pull_request_review.*',
'issue_comment.*'
]
this.supportedSettings = {
updated_at: {
Expand Down
3 changes: 2 additions & 1 deletion lib/validators/assignee.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ class Assignee extends Validator {
this.supportedEvents = [
'pull_request.*',
'pull_request_review.*',
'issues.*'
'issues.*',
'issue_comment.*'
]

this.supportedSettings = {
Expand Down
4 changes: 3 additions & 1 deletion lib/validators/author.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ class Author extends Validator {
super('author')
this.supportedEvents = [
'pull_request.*',
'pull_request_review.*'
'pull_request_review.*',
'issues.*',
'issue_comment.*'
]
this.supportedSettings = {
must_include: {
Expand Down
3 changes: 2 additions & 1 deletion lib/validators/description.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ class Description extends Validator {
this.supportedEvents = [
'pull_request.*',
'pull_request_review.*',
'issues.*'
'issues.*',
'issue_comment.*'
]
this.supportedSettings = {
no_empty: {
Expand Down
3 changes: 2 additions & 1 deletion lib/validators/label.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ class Label extends Validator {
this.supportedEvents = [
'pull_request.*',
'pull_request_review.*',
'issues.*'
'issues.*',
'issue_comment.*'
]
this.supportedSettings = {
no_empty: {
Expand Down
3 changes: 2 additions & 1 deletion lib/validators/title.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ class Title extends Validator {
this.supportedEvents = [
'pull_request.*',
'pull_request_review.*',
'issues.*'
'issues.*',
'issue_comment.*'
]
this.supportedSettings = {
no_empty: {
Expand Down