Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add buildpacks for building docker image #762

Closed
wants to merge 1 commit into from

feat: Add buildpacks for building docker image

d66de82
Select commit
Loading
Failed to load commit list.
Closed

feat: Add buildpacks for building docker image #762

feat: Add buildpacks for building docker image
d66de82
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable failed Jun 25, 2024 in 1s

3/4 Fail(s): DESCRIPTION, APPROVALS, OR

Status: FAIL

    Here are some stats of the run:
    4 validations were ran.
    1 PASSED
    3 FAILED

Details

✔️ Validator: TITLE

  • ✔️ title must include '^(feat|docs|chore|fix|refactor|test|style|perf)((\w+))?:.+$'
    Input : feat: Add buildpacks for building docker image
    Settings : {"must_include":{"regex":"^(feat|docs|chore|fix|refactor|test|style|perf)(\\(\\w+\\))?:.+$","message":"Semantic release conventions must be followed."}}

❌ Validator: DESCRIPTION

  • There are incomplete TODO task(s) unchecked.
    Input : - Use semantic-release github action
  • Use buildpack for optimized docker images
    • Only build amd64 image as arm is not supported by now from paketo buildpacks
    • smaller image size 350 vs 100mb now
    • publishes latest and versioned tag
  • Remove unnecessary matrix build from test
  • Add config to package.json that the package is public (as the github action fails to publish to npmjs otherwise with 402)

npmjs:
image
docker:
image

  • Test that merging PR creates new version

  • Add changelog entry

     Settings : ```{"must_exclude":{"regex":"\\[ \\]","message":"There are incomplete TODO task(s) unchecked."}}```
    

❌ Validator: APPROVALS

  • approvals count is less than "1"
    Input :
    Settings : {"min":{"count":1}}
  • (approvals: jusx required OR approvals: shine2lay required)
    Input :
    Settings : {"or":[{"required":{"reviewers":["jusx"]}},{"required":{"reviewers":["shine2lay"]}}]}

❌ Validator: OR

  • ✔️ Option 1: And: Option 1: title: title must include '^(feat|fix)((\w+))?:.+$'
    Input : feat: Add buildpacks for building docker image
    Settings : {"must_include":{"regex":"^(feat|fix)(\\(\\w+\\))?:.+$"}}
  • Option 1: And: Option 2: changeset: new features or fixes needed to be logged to the changelog
    Input : .github/workflows/docker.yml,.github/workflows/release.yml,.github/workflows/testing.yml,Dockerfile,package.json
    Settings : {"must_include":{"regex":"docs/changelog.rst","message":"new features or fixes needed to be logged to the changelog"}}
  • Option 2: title: new features or fixes needed to be logged to the changelog
    Input : feat: Add buildpacks for building docker image
    Settings : {"must_exclude":{"regex":"^(feat|fix)(\\(\\w+\\))?:.+$","message":"new features or fixes needed to be logged to the changelog"}}