Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Docker image not working #753

Merged
merged 11 commits into from
Jun 10, 2024
Merged

fix: Docker image not working #753

merged 11 commits into from
Jun 10, 2024

Conversation

Ch4s3r
Copy link
Contributor

@Ch4s3r Ch4s3r commented Jun 10, 2024

The old Dockerfile was using nodejs version 16 and not building at all.
This PR adds a new setup created with docker init.
It uses node 18 now as stated in the package.json.

These versions need to be kept in sync, so updating the nodejs version must also happen in the Dockerfile.

Executing the new docker image works:

image

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (a675dcf) to head (60ea3c0).
Report is 3 commits behind head on master.

Current head 60ea3c0 differs from pull request most recent head 1f6715c

Please upload reports for the commit 1f6715c to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #753   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files         110      110           
  Lines        2878     2881    +3     
  Branches      578      581    +3     
=======================================
+ Hits         2674     2677    +3     
  Misses        185      185           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1,5 +1,7 @@
CHANGELOG
=====================================
| June 10, 2024: fix: Docker image not working `#753 <https://github.com/mergeability/mergeable/pull/753>`_
| June 10, 2024: feat: publish multi arch docker image to dockerhub `#751 <https://github.com/mergeability/mergeable/pull/751>`_
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added changelog entry for previous PR

@Ch4s3r
Copy link
Contributor Author

Ch4s3r commented Jun 10, 2024

@shine2lay @jusx please have a look :)

@shine2lay shine2lay merged commit 3beeb24 into mergeability:master Jun 10, 2024
2 checks passed
Copy link

🎉 This PR is included in version 2.18.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants