-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] add an option for queryStr separator #129
Conversation
ca0c850
to
0ff4033
Compare
Can you include a functional test plan in the PR description (i.e. an input HCL config, the current result of running the query, and the new result of running the query)? I'm not sure I quite understand where exactly these non- |
As I stated in the PR description, this PR tries to add a way to specify a charactor other than "." as a query separator in HCLEditor due to this.
I think the unit tests I added are enough for this change. Are there more tests you'd like to see for this change? |
I'm trying to understand where a non- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is meant to support provider aliasing1 left hand side operands as part of the query.
WHAT
(Write the change being made with this pull request)
title
WHY
(Write the motivation why you submit this pull request)
Terraform allows comma-separated attributes (e.g. aliased providers like google.common inside a module). In order to modify attributes with comma in its name, we need a way to specify the queryStr split separator charactor.
Behavior
given:
where:
then:
Because queryStr considers all the commas as the query separator.
target: