Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample App] State saving with SavedStateHandle #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KeithYokoma
Copy link
Contributor

@KeithYokoma KeithYokoma commented Jun 22, 2020

It seems we are trying to restore the state from SavedStateHandle but not saving the state 😢 , so this PR fixes to save the state with SavedStateHandle properly.

@KeithYokoma KeithYokoma self-assigned this Jun 22, 2020
@KeithYokoma KeithYokoma requested a review from yhanada June 22, 2020 05:28
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2020

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   56.16%   56.16%           
=======================================
  Files           1        1           
  Lines          73       73           
  Branches       27       27           
=======================================
  Hits           41       41           
  Misses         23       23           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a5bf45...0a0c1d1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants