Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added subtype in poi #338

Merged
merged 6 commits into from
Aug 22, 2024
Merged

added subtype in poi #338

merged 6 commits into from
Aug 22, 2024

Conversation

vicorrea25
Copy link
Contributor

📝 Description

Add field sponsor_id in point_of_interaction request

✅ Checklist:

  • I followed the instructions indicated in Contribution Guidelines
  • I added the changes to CHANGELOG
  • Added the necessary tests for the code or functionality that I'm working on
  • I ran the tests and made sure they work
  • My branch coverage is at least 80%
  • I verified the style of my code matches the one in the project

🧰 How to reproduce

  • Not Apply.
  • Step by step of how to test, specially for bugs.
  • Links of external docs.

📸 Screenshots

  • Not Apply.
  • Before and after, if it's a fix for a bug.

📄 References

  • Not Apply.
  • Links do external documentation.
  • Diagrams.
  • Useful links.

@vicorrea25
Copy link
Contributor Author

rp retest

1 similar comment
@danielen-meli
Copy link
Contributor

rp retest

@vicorrea25 vicorrea25 dismissed andreagostinho-meli’s stale review August 22, 2024 17:58

The merge-base changed after approval.

@andreagostinho-meli andreagostinho-meli dismissed their stale review August 22, 2024 18:01

The merge-base changed after approval.

@danielen-meli danielen-meli merged commit 2cd021d into master Aug 22, 2024
3 checks passed
@andreagostinho-meli andreagostinho-meli deleted the feature/add-poi-subtype branch August 22, 2024 18:33
@Fernando-Santana-j Fernando-Santana-j mentioned this pull request Sep 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielen-meli danielen-meli danielen-meli approved these changes

@andreagostinho-meli andreagostinho-meli andreagostinho-meli approved these changes

@mariannebiancamb mariannebiancamb Awaiting requested review from mariannebiancamb

@kelvincarvalhosilva kelvincarvalhosilva Awaiting requested review from kelvincarvalhosilva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vicorrea25 @danielen-meli @andreagostinho-meli