Skip to content
This repository has been archived by the owner on Feb 10, 2022. It is now read-only.

Country support and improvements #11

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

lubc
Copy link

@lubc lubc commented Oct 13, 2016

Hey,

This PR fixes the issue #10 and also adds some improvements.

All the changes:

  • Allows to set a country code in auth_url method
  • Removes config.yml file and declares all the constants in lib/constants.rb
  • Adds Rspec dependency, updates syntax in spec/meli_spec.rb and adds coverage for auth_url
  • Fixes indentation
  • Updates README.md

Copy link

@daniduarte daniduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's necesary

Copy link

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good! 👍

@lubc
Copy link
Author

lubc commented Oct 19, 2016

@Phaael @prenzier Could you review this? Thanks!

@r1goo
Copy link

r1goo commented Feb 24, 2017

Thanks bro!

@r1goo
Copy link

r1goo commented Feb 25, 2017

Why are taken so long to merge this thing up? I just cant solve the problem with the BR redirection.

@raphaeljlps
Copy link

This is so frustrating, I'm trying to build something with mercadolibre
and lost a ton of time having issues that this PR fixes,
is this repo not maintained anymore?

could someone from ML please, merge this wonderful PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants