chore: add event for rebalance #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbow61
approved these changes
Nov 19, 2025
| require( | ||
| totalBoldDeposits >= MIN_BOLD_AFTER_REBALANCE, "Total Bold deposits must be >= MIN_BOLD_AFTER_REBALANCE" | ||
| ); | ||
| emit RebalanceExecuted(amountCollIn, amountStableOut); |
There was a problem hiding this comment.
nit: maybe we can rename from stable to debt here to be more consistent
🤔
Author
There was a problem hiding this comment.
I decided to keep it like this because calling Rebalance from stable to debt in a function that swaps collateral to stable did not feel right
Andrew718PLTS
approved these changes
Nov 19, 2025
nvtaveras
added a commit
that referenced
this pull request
Nov 25, 2025
### Description First iteration of fixes that came up as a result of the Chainsecurity audit. Some issues are still pending and will be fixed in a future PR. List of fixes included: - **5.1** - Batch Manager Is Not Deleted in kickFromBatch #20 - **5.2** - Incorrect StabilityPool Interface #23 - **5.3** - Rebalances Are Partially Allowed During Shutdown #24 - **5.5** - Swapping Collateral Does Not Accrue Interest #19 - **6.1** - Insufficient Check in SystemParams #25 - **6.2** - LiquidityStrategy Cannot Be Changed mento-protocol/mento-core#642 - **6.5** - Missing Sanity Checks #26 - **6.6** - Redistribution Penalty Must Be Smaller Than MCR #27 - **6.8** - Whitepaper Deviations mento-protocol/whitepaper#3 - **6.9** - minDebt Bounds Do Not Allow Configuring Low-Value Currencies Correctly #28 - **6.10** - swapCollateralForStable Event Indistinguishable From Liquidations #29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes 6.10) swapCollateralForStable Event Indistinguishable From Liquidations by emitting a rebalance event