[task] Fix return statement missing on some tasks (FriendsOfSymfony1#353

)
mentalstring · Apr 12, 2024 · 27fbf07 · 27fbf07
1 parent 7fecee2
commit 27fbf07
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/lib/task/test/sfTestFunctionalTask.class.php b/lib/task/test/sfTestFunctionalTask.class.php
@@ -108,5 +108,7 @@ protected function execute($arguments = [], $options = [])
 
             return $ret;
         }
+
+        return 0;
     }
 }
diff --git a/lib/task/test/sfTestPluginTask.class.php b/lib/task/test/sfTestPluginTask.class.php
@@ -67,6 +67,6 @@ protected function execute($arguments = [], $options = [])
         $finder = sfFinder::type('file')->follow_link()->name('*Test.php');
         $h->register($finder->in($h->base_dir));
 
-        return $h->run();
+        return $h->run() ? 0 : 1;
     }
 }
diff --git a/lib/task/test/sfTestUnitTask.class.php b/lib/task/test/sfTestUnitTask.class.php
@@ -102,5 +102,7 @@ protected function execute($arguments = [], $options = [])
 
             return $ret;
         }
+
+        return 0;
     }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -108,5 +108,7 @@ protected function execute($arguments = [], $options = []) @@
                 return $ret;
             }
+            return 0;
         }
     }