Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show settings sidebar panel when chat sidebar is closed #4766

Merged
merged 3 commits into from
Mar 24, 2025

Conversation

sdhrt
Copy link
Contributor

@sdhrt sdhrt commented Mar 1, 2025

Describe Your Changes

  • Show sidebar panel when navigating to settings, even when chat sidebar is closed for better navigation

Fixes Issues

#4705

Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-menlo
Copy link
Contributor

@sdhrt could you please help us fix the linter issues?

@sdhrt
Copy link
Contributor Author

sdhrt commented Mar 6, 2025

Currently trying to fix the side effects. Will fix the linter issue too.

@sdhrt sdhrt force-pushed the settings-sidebar branch 2 times, most recently from 96b92b0 to 71607a1 Compare March 6, 2025 08:07
@sdhrt sdhrt requested a review from louis-menlo March 6, 2025 08:19
Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-menlo louis-menlo merged commit 3ce6b30 into menloresearch:dev Mar 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants