[WC-3297] Signature web by gjulivan · Pull Request #2138 · mendix/web-widgets

gjulivan · 2026-03-16T13:14:26Z

Pull request type

Description

packages/pluggableWidgets/signature-web/src/__tests__/AppEvents.spec.tsx

packages/pluggableWidgets/signature-web/src/components/Alert.tsx

packages/pluggableWidgets/signature-web/src/assets/Signature.icon.dark.svg

packages/pluggableWidgets/signature-web/src/ui/SignaturePreview.css

packages/pluggableWidgets/signature-web/src/assets/Signature.icon.dark.png

packages/pluggableWidgets/signature-web/src/package.xml

packages/pluggableWidgets/signature-web/src/Signature.editorConfig.ts

packages/pluggableWidgets/signature-web/src/Signature.tsx

packages/pluggableWidgets/signature-web/CHANGELOG.md

packages/pluggableWidgets/signature-web/package.json

r0b1n · 2026-03-26T10:34:54Z

packages/pluggableWidgets/signature-web/src/components/Signature.tsx

+        if (imageDataUrl) {
+            imageSource.setValue(Utils.convertUrlToBlob(imageDataUrl));
+        }
+
+        // Trigger microflow to update signature attribute
+        if (onSignEndAction) {
+            onSignEndAction(imageDataUrl);
+        }


Looking at the code, maybe it makes more sense to handle everything in onSignEndAction instead of scattering business logic between two places (here and wherever onSignEndAction is defined).

r0b1n · 2026-03-26T10:39:12Z

packages/pluggableWidgets/signature-web/README.md

@@ -0,0 +1,3 @@
+<!-- TODO: Update marketplace URL -->
+
+Please see [App Events](https://docs.mendix.com/appstore/widgets/) in the Mendix documentation for details.


r0b1n · 2026-03-26T10:40:13Z

packages/pluggableWidgets/signature-web/package.json

+        "@mendix/widget-plugin-hooks": "workspace:*",
+        "@mendix/widget-plugin-platform": "workspace:*",
+        "@mendix/widget-plugin-test-utils": "workspace:*",
+        "cross-env": "^7.0.3"


Looks like we don't use this

r0b1n · 2026-03-26T10:41:18Z

packages/pluggableWidgets/signature-web/package.json

+    },
+    "packagePath": "com.mendix.widget.web",
+    "marketplace": {
+        "minimumMXVersion": "10.8.0",


Must be higher that that.

set to 11.8

packages/pluggableWidgets/signature-web/mendix-pluggable-widgets-tools.tgz

packages/pluggableWidgets/signature-web/src/Signature.xml

r0b1n · 2026-03-26T10:50:58Z

packages/pluggableWidgets/signature-web/src/utils/customTypes.ts

+    onSignEndAction?: (imageUrl?: string) => void;
+    wrapperStyle?: object;
+    readOnly: boolean;
+}


It is kind of confusing that is removes property and then reads it with the same name onSignEndAction and different signature. Also some properties are redefined as is, like readOnly or showGrid. I believe, if we need to change the properties shape we better pre-process them and give them a meaningful shape before passing to the underlying components. For example we can define in types that if we don't need to show grid, grid* properties are not defined. See Barcode generator for a good example.

packages/pluggableWidgets/signature-web/src/utils/useResizeObserver.ts

packages/pluggableWidgets/signature-web/src/utils/useSignaturePad.ts

r0b1n · 2026-03-26T10:57:03Z

packages/pluggableWidgets/signature-web/src/utils/Utils.ts

parseStyle in this file is not being used

packages/pluggableWidgets/signature-web/src/Signature.tsx

gjulivan requested a review from a team as a code owner March 16, 2026 13:14

github-actions bot added the signature-web label Mar 16, 2026

gjulivan changed the title ~~Signature web~~ [WC-3297] Signature web Mar 16, 2026

gjulivan force-pushed the signature-web branch from ebcf9cc to b0d9476 Compare March 16, 2026 13:14