Ubuntu 24.04 #7
Merged
Ubuntu 24.04 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug where the menu item would activate (click) on hover. This is because a list of submenu items of length 0 was being added. So I think GTK was 'activating' the menu to show the submenu items, but I had already attached the reboot command there.
Anyway I've added an if statement. Now it should behave itself.
Issue #2 #6
Ran into some problems.
❌ The /boot/grub/grub.cfg file is no longer readable on Ubuntu 24.04, so running the script gets access denied on Ubuntu 24.04. I'm going to have to find a way to read this file or run this script as root? I definitely don't want to modify its permissions.
I modified the .desktop file and put pkexec in front of grub-reboot-picker. I used polkit to allow grub-reboot-picker. Wish there were a narrower way of allowing this, just access to one specific file. I think polkit isn't meant for supernarrow access though.