Skip to content

Conversation

@danielskinstad
Copy link
Contributor

Ticket: MEN-8871

@danielskinstad danielskinstad requested a review from a team as a code owner November 24, 2025 19:58
@mender-test-bot
Copy link

@danielskinstad, start a full integration test pipeline with:

  • mentioning me and start integration pipeline

my commands and options

You can prevent me from automatically starting CI pipelines:

  • if your pull request title starts with "[NoCI] ..."

You can trigger a client pipeline on multiple prs with:

  • mentioning me and start client pipeline --pr mender/127 --pr mender-connect/255

You can trigger GitHub->GitLab branch sync with:

  • mentioning me and sync

You can cherry pick to a given branch or branches with:

  • mentioning me and:
 cherry-pick to:
 * 1.0.x
 * 2.0.x

Copy link
Member

@lluiscampos lluiscampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the current state of this test framework, your new tests is pretty good. I like a lot that we are improving the Python code itself, for example the dataclass and the contextmanager. Thank you.

See comments below. I didn't find anything explicit to block the PR on, but I would appreciate some discussions before final approval.

Copy link
Member

@lluiscampos lluiscampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look pretty decent now. Thank you.

Comment on lines +36 to +54
tag_pattern = re.compile(r"^\d+\.\d+\.\d+$")
version = os.environ.get("MENDER_CONTAINER_MODULES_VERSION", "main")

base_url = "https://raw.githubusercontent.com/mendersoftware/mender-container-modules/refs"
file_path = "src/gen_docker-compose"

if tag_pattern.match(version):
ref_path = f"tags/{version}"
elif version.startswith("pull/"):
ref_path = version
else:
ref_path = f"heads/{version}"

url = f"{base_url}/{ref_path}/{file_path}"

subprocess.check_call(
["curl", "--fail", "--output", script_path, url,]
)
os.chmod(script_path, 0o755)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much of this we may want to reuse in the future. Just let's keep it in mind to refactor when needed.

@danielskinstad
Copy link
Contributor Author

@mender-test-bot start integration pipeline

@mender-test-bot
Copy link

Hello 😺 I created a pipeline for you here: Pipeline-2184598952

Build Configuration Matrix

Key Value
INTEGRATION_REV pull/2812/head
RUN_TESTS_FULL_INTEGRATION true

@danielskinstad
Copy link
Contributor Author

@mender-test-bot start integration pipeline

@mender-test-bot
Copy link

There was an error while syncing branches: POST https://gitlab.com/api/v4/projects/Northern%2Etech%2FMender%2Fintegration/protected_branches: 409 {message: Protected branch 'pr_2812_protected' already exists} returned error: POST https://gitlab.com/api/v4/projects/Northern%2Etech%2FMender%2Fintegration/protected_branches: 409 {message: Protected branch 'pr_2812_protected' already exists} returned error: POST https://gitlab.com/api/v4/projects/Northern%2Etech%2FMender%2Fintegration/protected_branches: 409 {message: Protected branch 'pr_2812_protected' already exists} returned error: POST https://gitlab.com/api/v4/projects/Northern%2Etech%2FMender%2Fintegration/protected_branches: 409 {message: Protected branch 'pr_2812_protected' already exists}

@danielskinstad
Copy link
Contributor Author

@mender-test-bot start integration pipeline

@mender-test-bot
Copy link

There was an error while syncing branches: POST https://gitlab.com/api/v4/projects/Northern%2Etech%2FMender%2Fintegration/protected_branches: 409 {message: Protected branch 'pr_2812_protected' already exists} returned error: POST https://gitlab.com/api/v4/projects/Northern%2Etech%2FMender%2Fintegration/protected_branches: 409 {message: Protected branch 'pr_2812_protected' already exists} returned error: POST https://gitlab.com/api/v4/projects/Northern%2Etech%2FMender%2Fintegration/protected_branches: 409 {message: Protected branch 'pr_2812_protected' already exists} returned error: POST https://gitlab.com/api/v4/projects/Northern%2Etech%2FMender%2Fintegration/protected_branches: 409 {message: Protected branch 'pr_2812_protected' already exists}

@danielskinstad
Copy link
Contributor Author

@mender-test-bot start integration pipeline

@mender-test-bot
Copy link

Hello 😺 I created a pipeline for you here: Pipeline-2185272210

Build Configuration Matrix

Key Value
INTEGRATION_REV pull/2812/head
RUN_TESTS_FULL_INTEGRATION true

@danielskinstad
Copy link
Contributor Author

@mender-test-bot start integration pipeline

@mender-test-bot
Copy link

There was an error while syncing branches: [push -f -o ci.skip --set-upstream gitlab pr_2812_protected] returned error: remote: GitLab: You are not allowed to force push code to a protected branch on this project.
To gitlab.com:Northern.tech/Mender/integration
! [remote rejected] pr_2812_protected -> pr_2812_protected (pre-receive hook declined)
error: failed to push some refs to 'gitlab.com:Northern.tech/Mender/integration'
: exit status 1 returned error: There was an error syncing branches: [push -f -o ci.skip --set-upstream gitlab pr_2812_protected] returned error: remote: GitLab: You are not allowed to force push code to a protected branch on this project.
To gitlab.com:Northern.tech/Mender/integration
! [remote rejected] pr_2812_protected -> pr_2812_protected (pre-receive hook declined)
error: failed to push some refs to 'gitlab.com:Northern.tech/Mender/integration'
: exit status 1

@danielskinstad
Copy link
Contributor Author

@mender-test-bot start integration pipeline

@mender-test-bot
Copy link

Hello 😺 I created a pipeline for you here: Pipeline-2188556685

Build Configuration Matrix

Key Value
INTEGRATION_REV pull/2812/head
RUN_TESTS_FULL_INTEGRATION true

Ticket: MEN-8871

Signed-off-by: Daniel Skinstad Drabitzius <[email protected]>
@danielskinstad
Copy link
Contributor Author

@mender-test-bot start integration pipeline

@mender-test-bot
Copy link

There was an error while syncing branches: [push -f -o ci.skip --set-upstream gitlab pr_2812_protected] returned error: remote: GitLab: You are not allowed to force push code to a protected branch on this project.
To gitlab.com:Northern.tech/Mender/integration
! [remote rejected] pr_2812_protected -> pr_2812_protected (pre-receive hook declined)
error: failed to push some refs to 'gitlab.com:Northern.tech/Mender/integration'
: exit status 1 returned error: There was an error syncing branches: [push -f -o ci.skip --set-upstream gitlab pr_2812_protected] returned error: remote: GitLab: You are not allowed to force push code to a protected branch on this project.
To gitlab.com:Northern.tech/Mender/integration
! [remote rejected] pr_2812_protected -> pr_2812_protected (pre-receive hook declined)
error: failed to push some refs to 'gitlab.com:Northern.tech/Mender/integration'
: exit status 1

@danielskinstad
Copy link
Contributor Author

@mender-test-bot start integration pipeline

@mender-test-bot
Copy link

Hello 😺 I created a pipeline for you here: Pipeline-2188673063

Build Configuration Matrix

Key Value
INTEGRATION_REV pull/2812/head
RUN_TESTS_FULL_INTEGRATION true

@danielskinstad danielskinstad merged commit f5672a7 into mendersoftware:master Dec 1, 2025
2 checks passed
@danielskinstad danielskinstad deleted the docker-compose-tests branch December 1, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants