-
Notifications
You must be signed in to change notification settings - Fork 83
test: integration tests for docker-compose UM #2812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: integration tests for docker-compose UM #2812
Conversation
|
@danielskinstad, start a full integration test pipeline with:
my commands and optionsYou can prevent me from automatically starting CI pipelines:
You can trigger a client pipeline on multiple prs with:
You can trigger GitHub->GitLab branch sync with:
You can cherry pick to a given branch or branches with:
|
278e78e to
a4f7f5a
Compare
lluiscampos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the current state of this test framework, your new tests is pretty good. I like a lot that we are improving the Python code itself, for example the dataclass and the contextmanager. Thank you.
See comments below. I didn't find anything explicit to block the PR on, but I would appreciate some discussions before final approval.
a4f7f5a to
6b993f6
Compare
lluiscampos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests look pretty decent now. Thank you.
| tag_pattern = re.compile(r"^\d+\.\d+\.\d+$") | ||
| version = os.environ.get("MENDER_CONTAINER_MODULES_VERSION", "main") | ||
|
|
||
| base_url = "https://raw.githubusercontent.com/mendersoftware/mender-container-modules/refs" | ||
| file_path = "src/gen_docker-compose" | ||
|
|
||
| if tag_pattern.match(version): | ||
| ref_path = f"tags/{version}" | ||
| elif version.startswith("pull/"): | ||
| ref_path = version | ||
| else: | ||
| ref_path = f"heads/{version}" | ||
|
|
||
| url = f"{base_url}/{ref_path}/{file_path}" | ||
|
|
||
| subprocess.check_call( | ||
| ["curl", "--fail", "--output", script_path, url,] | ||
| ) | ||
| os.chmod(script_path, 0o755) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much of this we may want to reuse in the future. Just let's keep it in mind to refactor when needed.
|
@mender-test-bot start integration pipeline |
|
Hello 😺 I created a pipeline for you here: Pipeline-2184598952 Build Configuration Matrix
|
|
@mender-test-bot start integration pipeline |
|
There was an error while syncing branches: POST https://gitlab.com/api/v4/projects/Northern%2Etech%2FMender%2Fintegration/protected_branches: 409 {message: Protected branch 'pr_2812_protected' already exists} returned error: POST https://gitlab.com/api/v4/projects/Northern%2Etech%2FMender%2Fintegration/protected_branches: 409 {message: Protected branch 'pr_2812_protected' already exists} returned error: POST https://gitlab.com/api/v4/projects/Northern%2Etech%2FMender%2Fintegration/protected_branches: 409 {message: Protected branch 'pr_2812_protected' already exists} returned error: POST https://gitlab.com/api/v4/projects/Northern%2Etech%2FMender%2Fintegration/protected_branches: 409 {message: Protected branch 'pr_2812_protected' already exists} |
|
@mender-test-bot start integration pipeline |
|
There was an error while syncing branches: POST https://gitlab.com/api/v4/projects/Northern%2Etech%2FMender%2Fintegration/protected_branches: 409 {message: Protected branch 'pr_2812_protected' already exists} returned error: POST https://gitlab.com/api/v4/projects/Northern%2Etech%2FMender%2Fintegration/protected_branches: 409 {message: Protected branch 'pr_2812_protected' already exists} returned error: POST https://gitlab.com/api/v4/projects/Northern%2Etech%2FMender%2Fintegration/protected_branches: 409 {message: Protected branch 'pr_2812_protected' already exists} returned error: POST https://gitlab.com/api/v4/projects/Northern%2Etech%2FMender%2Fintegration/protected_branches: 409 {message: Protected branch 'pr_2812_protected' already exists} |
|
@mender-test-bot start integration pipeline |
|
Hello 😺 I created a pipeline for you here: Pipeline-2185272210 Build Configuration Matrix
|
6b993f6 to
264f17a
Compare
|
@mender-test-bot start integration pipeline |
|
There was an error while syncing branches: [push -f -o ci.skip --set-upstream gitlab pr_2812_protected] returned error: remote: GitLab: You are not allowed to force push code to a protected branch on this project. |
|
@mender-test-bot start integration pipeline |
|
Hello 😺 I created a pipeline for you here: Pipeline-2188556685 Build Configuration Matrix
|
Ticket: MEN-8871 Signed-off-by: Daniel Skinstad Drabitzius <[email protected]>
264f17a to
ca1e912
Compare
|
@mender-test-bot start integration pipeline |
|
There was an error while syncing branches: [push -f -o ci.skip --set-upstream gitlab pr_2812_protected] returned error: remote: GitLab: You are not allowed to force push code to a protected branch on this project. |
|
@mender-test-bot start integration pipeline |
|
Hello 😺 I created a pipeline for you here: Pipeline-2188673063 Build Configuration Matrix
|
Ticket: MEN-8871