feat(python-sdk): Make API key optional for self-hosted instances #990
+59
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervices in FirecrawlApp
nickscamara
reviewed
Dec 20, 2024
apps/python-sdk/pyproject.toml
Outdated
| @@ -12,7 +12,9 @@ dependencies = [ | |||
| "requests", | |||
| "python-dotenv", | |||
| "websockets", | |||
| "nest-asyncio" | |||
| "nest-asyncio", | |||
| "pytest>=8.3.4", | |||
There was a problem hiding this comment.
we might not need pytest here, @rafaelmmiller lmk.
There was a problem hiding this comment.
I have removed pytest from pyproject.toml but while testing i get this error, thats why I added it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #961
Description:
Make API key validation conditional based on API URL. API key is now only required when using cloud service (api.firecrawl.dev). This allows easier self-hosting by removing API key requirement for local/self-hosted instances.
Changes: