Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(crawl): Similar URL deduplication #878

Merged
merged 4 commits into from
Nov 11, 2024
Merged

feat(crawl): Similar URL deduplication #878

merged 4 commits into from
Nov 11, 2024

Conversation

mogery
Copy link
Member

@mogery mogery commented Nov 8, 2024

This PR adds some important features:

  • If a crawl's scrape was redirected, the target URL is also locked, preventing it from being scraped again later.
  • lockURL now generates similar URLs that will presumably return the same content, and it will lock all of them, preventing the same content from being scraped twice. This can be disabled with the deduplicateSimilarURLs crawl parameter (on by default).
  • Added missing parameters to the JS SDK.

@nickscamara
Copy link
Member

Worth adding tests to the dedup stuff

@nickscamara nickscamara merged commit 56a1ac0 into main Nov 11, 2024
1 check failed
@mogery mogery deleted the mog/deduplicate-urls branch November 11, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickscamara nickscamara nickscamara left review comments

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mogery @nickscamara