feat: small room optimisation of the apps/api Dockerfile image #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sanix-Darker feel free to assign me for reviewing when it's done! |
Sanix-Darker
commented
Jul 7, 2024
@rafaelsideguide it's ready to be reviewed... i don't have right to assign you... |
|
|
||
| FROM base | ||
| RUN apt-get update -qq && \ | ||
| apt-get install --no-install-recommends -y chromium chromium-sandbox && \ |
There was a problem hiding this comment.
@nickscamara do we need chromium-sandbox?
rafaelsideguide
approved these changes
Jul 11, 2024
|
Is there any other actions I need to make for this PR please ? @nickscamara |
|
@Sanix-Darker will look into it! |
|
Hey @Sanix-Darker, I encountered some errors while testing this PR. Here are the logs: 2024-08-12 18:08:59 node:internal/modules/cjs/loader:1148
2024-08-12 18:08:59 throw err;
2024-08-12 18:08:59 ^
2024-08-12 18:08:59
2024-08-12 18:08:59 Error: Cannot find module '/app/pnpm'
2024-08-12 18:08:59 at Module._resolveFilename (node:internal/modules/cjs/loader:1145:15)
2024-08-12 18:08:59 at Module._load (node:internal/modules/cjs/loader:986:27)
2024-08-12 18:08:59 at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:174:12)
2024-08-12 18:08:59 at node:internal/main/run_main_module:28:49 {
2024-08-12 18:08:59 code: 'MODULE_NOT_FOUND',
2024-08-12 18:08:59 requireStack: []
2024-08-12 18:08:59 }
2024-08-12 18:08:59
2024-08-12 18:08:59 Node.js v20.16.0I also wasn't able to test it on our staging environment. Could you help figure out how to fix this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEFORE & AFTER
0.45GB of difference.