Remove node modules from the repository

[bernarda78]

Hi,

I've worked on #80.

I have removed the node_modules folder from the repository. The depency are now installed during make execution. During this step, a call is made to npm ci which will install package registered in package.json and package-lock.json files.

Why npm rather than yarn ? Both npm and yarn are package manager that use package.json. In both cases, there is the issue of bootstraping. I initially wanted to move with yarn, but npm seemed to be already used to manage the dependency, so I kept to it.

A few things that could be improved:

• Add a dependency to npm, but may be it could be bootstraped ?
• There is no check that npm actually exists on the system.
• npm message at the installation is a bit verbose.
• There are remaining dependency living in the repository, for the src/webview/client-files/. I have not yet looked how to replace them.

Feel free to ask anything,
Thanks.

[svalat]

Hi @bernarda78, thanks very much for the patch, that's welcome, I will give a look and play a bit with it.

In principle as you applied the same logic than numaprof I should in principle be able to call npm only when using the git repo. When I make a release (I probably need to patch the dev/gen-archive.sh so it make just as numaprof to produce an archive for release which does not require internet. That's important for clusteres who have no access to the net, also to improve reproductibility of the release itself.

Do you have time to look to add a commit in the PR for that ?

You can :

• look on : https://github.com/memtt/numaprof/blob/master/dev/gen-archive.sh
• Look in CMake script not to call NPM if the files are there, look on : https://github.com/memtt/numaprof/blob/master/src/webview/CMakeLists.txt

[svalat]

There is a FindNpm in numaprof which you can import also : https://github.com/memtt/numaprof/blob/master/cmake/FindNpm.cmake

[bernarda78]

Thank you for the information. I will look into it and get back to you.

[bernarda78]

Hi,

My last commit makes check for npm existence and works with the archive generation script (https://github.com/memtt/numaprof/blob/master/dev/gen-archive.sh).

[svalat]

I checked, everything looks to work as expected. I merge.

Thanks a lot for the PR.