Boombox async backmerge into new architecture #86
+182
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Łukasz Kita <[email protected]>
Co-authored-by: Łukasz Kita <[email protected]>
…/boombox into boombox-async-presetup
…ombox-async-backmerge
varsill
approved these changes
May 20, 2025
Merged
FelonEkonom
approved these changes
May 20, 2025
lib/boombox/internal_bin.ex
Outdated
Comment on lines
292
to
303
| @impl true | ||
| def handle_child_setup_completed(:udp_source, _ctx, state) do | ||
| {[notify_parent: :external_resource_ready], state} | ||
| end | ||
|
|
||
| def handle_child_setup_completed(:rtsp_source, _ctx, state) do | ||
| {[notify_parent: :external_resource_ready], state} | ||
| end | ||
|
|
||
| def handle_child_setup_completed(_child, _ctx, state) do | ||
| {[], state} | ||
| end |
There was a problem hiding this comment.
in majority of the plugins there is a convention to write @impl true before each callback match
lib/boombox/internal_bin.ex
Outdated
Comment on lines
292
to
299
| @impl true | ||
| def handle_child_setup_completed(:udp_source, _ctx, state) do | ||
| {[notify_parent: :external_resource_ready], state} | ||
| end | ||
|
|
||
| def handle_child_setup_completed(:rtsp_source, _ctx, state) do | ||
| {[notify_parent: :external_resource_ready], state} | ||
| end |
There was a problem hiding this comment.
Let's merge these two cases into one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boombox.async/2function for asynchronous execution, and modifies tests to use it.Boombox.run/2(and related internals), changing argument handling and process flow.await_source_ready/0,await_sink_ready/0,await_external_resource_ready/0).