Skip to content

Boombox async backmerge into new architecture #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
May 26, 2025
Merged

Conversation

wende
Copy link
Contributor

@wende wende commented May 5, 2025

  • Adds a new Boombox.async/2 function for asynchronous execution, and modifies tests to use it.
  • Refactors Boombox.run/2 (and related internals), changing argument handling and process flow.
  • Adds new helper functions (await_source_ready/0, await_sink_ready/0, await_external_resource_ready/0).
  • Updates test code to use dynamic ports and the new async API.

@wende wende marked this pull request as ready for review May 19, 2025 11:35
@wende wende requested review from varsill, mat-hek and FelonEkonom May 19, 2025 11:36
Copy link
Contributor

@varsill varsill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, I've left some minor comments

Comment on lines 292 to 303
@impl true
def handle_child_setup_completed(:udp_source, _ctx, state) do
{[notify_parent: :external_resource_ready], state}
end

def handle_child_setup_completed(:rtsp_source, _ctx, state) do
{[notify_parent: :external_resource_ready], state}
end

def handle_child_setup_completed(_child, _ctx, state) do
{[], state}
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in majority of the plugins there is a convention to write @impl true before each callback match

Comment on lines 292 to 299
@impl true
def handle_child_setup_completed(:udp_source, _ctx, state) do
{[notify_parent: :external_resource_ready], state}
end

def handle_child_setup_completed(:rtsp_source, _ctx, state) do
{[notify_parent: :external_resource_ready], state}
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge these two cases into one

@mat-hek mat-hek removed their request for review May 26, 2025 08:32
@wende wende merged commit f94f6e2 into master May 26, 2025
3 checks passed
@wende wende deleted the boombox-async-backmerge branch May 26, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants