-
Notifications
You must be signed in to change notification settings - Fork 4k
Consistent create_col
for the vectorstores
#2497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@parshvadaftari Can you please resolve the merge conflicts? |
@Dev-Khant Resolved the conflicts and formatted the code as well. |
Hey @parshvadaftari Can you please rebase your branch with |
990fd9a
to
bb5b677
Compare
@Dev-Khant Have resolved the conflicts, rebased it with main and made the |
Hey @parshvadaftari Can you please resolve the merge conflicts? |
e1073b2
to
b9b30ef
Compare
@Dev-Khant Have resolved the conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you also make changes to create_col
in mem0/vector_stores/base.py
?
@Dev-Khant I've made changes to it as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the changes for this file.
Description
Consistent
create_col
for vectorstoresFixes #2465
Type of change
How Has This Been Tested?
Checklist:
Maintainer Checklist
create_col
consistent for all Vector Stores #2465