Enhance Docker Security: Run Container as a Non-Root User #2224
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update modifies the Dockerfile to address a Trivy security warning
|
|
deshraj
approved these changes
Feb 19, 2025
|
Thanks for opening the PR. Changes look good. |
deshraj
approved these changes
Feb 20, 2025
|
@deshraj could we merge it ? or I need to change something. I see some tests are failing. not sure maybe missed something 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update modifies the Dockerfile to address a Trivy security warning
Description
This PR updates the Dockerfile to improve security by running the container as a non-root user, preventing privilege escalation risks and addressing Trivy's HIGH severity warning (DS002).
Changes Implemented:
✅ Added a new system user (appuser) and group (appgroup).
✅ Set ownership of /app to the non-root user.
✅ Moved pip install before switching users to prevent permission issues.
✅ Switched to USER appuser to follow best security practices.
Why This Change?
🔹 Mitigates security risks associated with running containers as root.
🔹 Complies with Docker security best practices.
🔹 Fixes Trivy HIGH severity warning (DS002).
References:
📌 vulnerability database: aquasec
Testing & Validation:
✅ Builds and runs successfully with uvicorn.
✅ Verified application runs correctly as appuser.
✅ Passed security scans without issues.
Please review and merge to enhance security. 🚀