Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvements] Improve the default prompt and data loader util functions #1272

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

deshraj
Copy link
Collaborator

@deshraj deshraj commented Feb 18, 2024

Description

Changes:

  • Make changes in the default prompt to yield better answers and reduce hallucinations
  • Rename var name 'meta_data' to 'metadata' for consistency
  • Refactor the clean_string method to parse the context properly

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (does not change functionality, e.g. code style improvements, linting)

How Has This Been Tested?

  • Unit Test

Sorry, something went wrong.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 18, 2024
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (9a11683) 56.59% compared to head (e981d81) 56.58%.

Files Patch % Lines
embedchain/loaders/slack.py 0.00% 3 Missing ⚠️
embedchain/loaders/rss_feed.py 0.00% 2 Missing ⚠️
embedchain/loaders/unstructured_file.py 0.00% 2 Missing ⚠️
embedchain/loaders/discord.py 0.00% 1 Missing ⚠️
embedchain/loaders/text_file.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1272      +/-   ##
==========================================
- Coverage   56.59%   56.58%   -0.01%     
==========================================
  Files         146      146              
  Lines        5955     5954       -1     
==========================================
- Hits         3370     3369       -1     
  Misses       2585     2585              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deshraj deshraj merged commit 6c12bc9 into main Feb 18, 2024
@deshraj deshraj deleted the user/dyadav/update-data-loader-and-prompt branch August 24, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant