Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dbt test bug fixes #650

Merged
merged 5 commits into from
Jun 14, 2023
Merged

fix: dbt test bug fixes #650

merged 5 commits into from
Jun 14, 2023

Conversation

pnadolny13
Copy link
Contributor

@pnadolny13 pnadolny13 commented Jun 14, 2023

Closes #643, #646

  • use project deployments table now to do joins properly. Previously we assumed deployments and envs matched and had a test to fail if they didnt. Just yesterday they started failing.
  • The other failing test was because the credit counts for orgs in cloud_org_dim and fact_cloud_executions didnt match. This was because cloud_org_dim uses the orgs table as its base and fact_cloud_executions uses the executions metadata table. A few orgs have been hard deleted from the orgs table but their executions still live in on the executions metadata table so when the test tried to diff them it was struggling with nulls. For now I coalesced to a "ORG_DELETED" bucket but can remove that once https://github.com/meltano/infra/issues/978 is done and the source is fixed.

@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 14:31 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 14:31 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:02 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:02 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:02 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:09 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:09 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:09 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:09 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:09 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:09 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:09 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:09 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:09 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:09 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 enabled auto-merge (squash) June 14, 2023 15:18
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:47 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:47 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:47 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:53 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:53 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:53 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:53 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:53 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:53 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:53 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:53 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:53 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 15:53 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 16:03 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 temporarily deployed to test June 14, 2023 16:17 — with GitHub Actions Inactive
@pnadolny13 pnadolny13 merged commit 95bc60b into main Jun 14, 2023
15 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor metadata + project schedules joins for cloud executions
1 participant