-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Avoid using requirements.txt files and rely on uv.lock #2911
Conversation
Reviewer's Guide by SourceryThis pull request migrates the project from using Flow Diagram: pre-commit configuration changesgraph LR
A[Start] --> B{Use uv-lock and uv-sync?}
B -- Yes --> C[Remove uv-export hooks]
C --> D[End]
B -- No --> D
style A fill:#f9f,stroke:#333,stroke-width:2px
style C fill:#ccf,stroke:#333,stroke-width:2px
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
5f181d1
to
43dc0b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2911 +/- ##
=======================================
Coverage 91.40% 91.40%
=======================================
Files 63 63
Lines 5291 5291
Branches 676 676
=======================================
Hits 4836 4836
Misses 321 321
Partials 134 134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #2911 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @edgarrmondragon - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a
uv pip compile
step to pre-compile the dependencies before syncing, potentially speeding up the installation process. - It might be worth exploring whether
uv pip install
can replaceuv sync
in some cases, as it could simplify the configuration.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates dependency management by replacing requirements.txt file usage with uv.lock–based workflows and commands. Key changes include:
- Updating .readthedocs.yml to use asdf and uv sync for dependency installation.
- Modifying uv export and sync usage in GitHub workflows and noxfile.py sessions.
- Adjusting the pyproject.toml dependency for xdoctest to include color support.
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
.readthedocs.yml | Replaces pip install with uv sync for ReadTheDocs dependencies |
pyproject.toml | Updates xdoctest dependency to include the "colors" extra |
.pre-commit-config.yaml | Removes uv-export hooks for exporting requirements files |
.github/workflows/codspeed.yml | Updates the codspeed workflow to use uv export and changes file path |
noxfile.py | Replaces session.install with uv sync across various sessions |
Files not reviewed (2)
- requirements/requirements.codspeed.txt: Language not supported
- requirements/requirements.typing.txt: Language not supported
Comments suppressed due to low confidence (3)
noxfile.py:60
- The 'mypy' session uses '--group=typing' along with extras that appear unrelated to type checking; please verify if the correct group is intended or if a different group (e.g., testing) should be used.
"--group=typing",
noxfile.py:148
- The 'dependencies' session's uv sync call does not specify a group, which may result in installing unintended sets of extras; consider adding the appropriate '--group' parameter if a specific group should be used.
"uv",
.github/workflows/codspeed.yml:57
- Ensure that the updated output file path (omitting the 'requirements/' prefix) is intentional and consistent with other parts of the workflow configuration.
uv export --no-editable --frozen --no-hashes --no-dev --all-extras --group benchmark --output-file requirements.codspeed.txt
uv sync
in Noxfile: https://nox.thea.codes/en/stable/cookbook.html#using-a-lockfileuv sync
for ReadTheDocs: https://docs.readthedocs.com/platform/latest/build-customization.html#install-dependencies-with-uvSummary by Sourcery
Migrate from
requirements.txt
files touv.lock
for dependency management. This change leveragesuv sync
to install dependencies based on the lockfile, and removes the usage ofrequirements.txt
files.Build:
requirements.txt
files withuv sync
for dependency installation innoxfile.py
.uv sync
for ReadTheDocs dependency installation..github/workflows/codspeed.yml
.uv-export
pre-commit hooks.xdoctest
extra to includecolors
CI: