Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow developers to set RESTStream.http_method #2807

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Dec 10, 2024

Follows from #2762


📚 Documentation preview 📚: https://meltano-sdk--2807.org.readthedocs.build/en/2807/

@edgarrmondragon edgarrmondragon self-assigned this Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (2882731) to head (9c46579).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2807      +/-   ##
==========================================
+ Coverage   91.27%   91.29%   +0.01%     
==========================================
  Files          62       62              
  Lines        5182     5190       +8     
  Branches      669      669              
==========================================
+ Hits         4730     4738       +8     
  Misses        319      319              
  Partials      133      133              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 10, 2024

CodSpeed Performance Report

Merging #2807 will not alter performance

Comparing edgarrmondragon/fix/allow-updates-http-method (9c46579) with main (2882731)

Summary

✅ 7 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/allow-updates-http-method branch from 4bafaae to 9c46579 Compare December 10, 2024 22:46
@edgarrmondragon edgarrmondragon merged commit 2ae5a1e into main Dec 10, 2024
36 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/fix/allow-updates-http-method branch December 10, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant