Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: SQL taps now require SQLAlchemy 2.0+ #2797

Merged
merged 1 commit into from
Dec 4, 2024
+7 −0
Merged

packaging: SQL taps now require SQLAlchemy 2.0+ #2797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading status checks…
packaging: SQL taps now require SQLAlchemy 2.0+
@edgarrmondragon
edgarrmondragon committed Dec 4, 2024
commit 8372a88b2364e65bcb7174adb183a91781d0fd28
3 changes: 3 additions & 0 deletions cookiecutter/tap-template/{{cookiecutter.tap_id}}/pyproject.toml
View file
Original file line number Diff line number Diff line change
@@ -38,6 +38,9 @@ fs-s3fs = { version = "~=1.1.1", optional = true }
{%- if cookiecutter.stream_type in ["REST", "GraphQL"] %}
requests = "~=2.32.3"
{%- endif %}
{%- if cookiecutter.stream_type == "SQL" %}
sqlalchemy = "~=2.0.36"
{%- endif %}

[tool.poetry.group.dev.dependencies]
pytest = ">=8"
4 changes: 4 additions & 0 deletions docs/guides/sql-tap.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Building SQL taps

```{warning}
Starting with version `0.43.0`, SQL taps require SQLAlchemy 2.0 or newer.
```

## Mapping SQL types to JSON Schema

Starting with version `0.41.0`, the Meltano Singer SDK provides a clean way to map SQL types to JSON Schema. This is useful when the SQL dialect you are using has custom types that need to be mapped accordingly to JSON Schema.