Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Added a class method to instantiate SQLToJSONSchema from the tap configuration #2781

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 28, 2024

@edgarrmondragon edgarrmondragon requested review from a team as code owners November 28, 2024 19:22
Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #2781 will not alter performance

Comparing edgarrmondragon/refactor/sqltojsonschema-fromconfig (2247407) with main (3d8e418)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.88%. Comparing base (3d8e418) to head (2247407).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2781   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files          62       62           
  Lines        5166     5170    +4     
  Branches      667      667           
=======================================
+ Hits         4695     4699    +4     
  Misses        330      330           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/sqltojsonschema-fromconfig branch 3 times, most recently from 0d5b11f to 0d9f7b9 Compare November 28, 2024 22:33
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/sqltojsonschema-fromconfig branch from 0d9f7b9 to 2247407 Compare November 28, 2024 22:35
@edgarrmondragon edgarrmondragon added this to the v0.43 milestone Nov 28, 2024
@edgarrmondragon edgarrmondragon self-assigned this Nov 28, 2024
@edgarrmondragon edgarrmondragon merged commit 3ad4615 into main Nov 28, 2024
36 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/sqltojsonschema-fromconfig branch November 28, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant